[GRASS-QA] GRASS QA: martinl |ogsf_proto.h GP2.c GV2.c map_obj.c | 67
clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Mon Oct 27 10:39:33 EDT 2008
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/include/ogsf_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/ogsf/GP2.c
*****************************************************************
Function
GP_alldraw_site(Begins at: 557, Ends at:566)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_attmode_color(Begins at: 284, Ends at:302)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_attmode_none(Begins at: 312, Ends at:323)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_delete_site(Begins at: 131, Ends at:156)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GP_draw_site(Begins at: 520, Ends at:552)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_Get_ClientData(Begins at: 599, Ends at:609)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_get_sitemode(Begins at: 224, Ends at:240)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
GP_get_sitename(Begins at: 208, Ends at:219)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_get_site_list(Begins at: 101, Ends at:121)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_get_trans(Begins at: 406, Ends at:422)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GP_get_zmode(Begins at: 365, Ends at:375)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_load_site(Begins at: 173, Ends at:195)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_new_site(Begins at: 63, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_num_sites(Begins at: 86, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_select_surf(Begins at: 433, Ends at:450)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_Set_ClientData(Begins at: 577, Ends at:589)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_set_sitemode(Begins at: 254, Ends at:270)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
GP_set_trans(Begins at: 383, Ends at:398)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GP_set_zmode(Begins at: 335, Ends at:354)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_site_exists(Begins at: 38, Ends at:55)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_surf_is_selected(Begins at: 497, Ends at:513)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GP_unselect_surf(Begins at: 461, Ends at:486)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 29 potentially cloned functions:
GS_lights_on GS_alldraw_surf GV_alldraw_vect GV_alldraw_fastvect GVL_alldraw_vol GVL_alldraw_wire GP_Get_ClientData GS_Get_ClientData GV_Get_ClientData GVL_Get_ClientData GP_attmode_none GS_Get_ClientData GV_Get_ClientData GVL_Get_ClientData GV_get_vectname GP_set_trans GV_new_vector GV_select_surf GS_Set_ClientData GS_get_wire_color GS_get_drawmode GV_Set_ClientData GVL_Set_ClientData GVL_isosurf_get_drawmode GVL_slice_get_drawmode GP_get_trans GV_surf_is_selected GV_unselect_surf
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_alldraw_site are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_lights_off
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_lights_on
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_alldraw_surf
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_alldraw_vect
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_alldraw_fastvect
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_alldraw_vol
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_alldraw_wire
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_attmode_none are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_Get_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_Get_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_Get_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_Get_ClientData
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_Get_ClientData are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_attmode_none
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_Get_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_Get_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_Get_ClientData
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_get_sitename are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_get_vectname
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_get_trans are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_set_trans
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_new_site are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_new_vector
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_select_surf are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_select_surf
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_Set_ClientData are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_Set_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_get_wire_color
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_get_drawmode
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_Set_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_Set_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_isosurf_get_drawmode
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_slice_get_drawmode
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_set_trans are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_get_trans
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_surf_is_selected are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_surf_is_selected
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c clones of GP_unselect_surf are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_unselect_surf
*****************************************************************
File :grass/trunk/lib/ogsf/GV2.c
*****************************************************************
Function
GV_alldraw_fastvect(Begins at: 486, Ends at:495)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_alldraw_vect(Begins at: 444, Ends at:453)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_delete_vector(Begins at: 131, Ends at:157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GV_draw_fastvect(Begins at: 462, Ends at:481)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_draw_vect(Begins at: 420, Ends at:439)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_Get_ClientData(Begins at: 528, Ends at:539)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_get_trans(Begins at: 304, Ends at:319)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GV_get_vectmode(Begins at: 259, Ends at:273)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GV_get_vectname(Begins at: 206, Ends at:217)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_get_vect_list(Begins at: 101, Ends at:121)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_load_vector(Begins at: 174, Ends at:193)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_new_vector(Begins at: 63, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_num_vects(Begins at: 86, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_select_surf(Begins at: 331, Ends at:349)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_Set_ClientData(Begins at: 506, Ends at:518)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_set_trans(Begins at: 281, Ends at:296)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GV_set_vectmode(Begins at: 231, Ends at:245)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GV_surf_is_selected(Begins at: 397, Ends at:413)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GV_unselect_surf(Begins at: 360, Ends at:386)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GV_vect_exists(Begins at: 38, Ends at:55)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 38 potentially cloned functions:
GS_lights_off GS_lights_on GS_alldraw_surf GV_alldraw_vect GVL_alldraw_vol GVL_alldraw_wire GP_alldraw_site GS_lights_off GS_lights_on GS_alldraw_surf GV_alldraw_fastvect GVL_alldraw_vol GVL_alldraw_wire GV_draw_vect GV_draw_fastvect GP_attmode_none GP_Get_ClientData GS_Get_ClientData GVL_Get_ClientData GVL_get_trans GV_set_vectmode GP_get_sitename GP_new_site GP_select_surf GP_Set_ClientData GS_Set_ClientData GS_get_wire_color GS_get_drawmode GVL_Set_ClientData GVL_isosurf_get_drawmode GVL_slice_get_drawmode GS_set_trans GS_get_trans GV_get_vectmode GP_surf_is_selected GP_unselect_surf GS_surf_exists
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_alldraw_fastvect are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_alldraw_site
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_lights_off
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_lights_on
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_alldraw_surf
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_alldraw_vect
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_alldraw_vol
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_alldraw_wire
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_alldraw_vect are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_alldraw_site
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_lights_off
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_lights_on
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_alldraw_surf
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_alldraw_fastvect
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_alldraw_vol
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_alldraw_wire
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_draw_fastvect are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_draw_vect
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_draw_vect are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_draw_fastvect
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_Get_ClientData are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_attmode_none
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_Get_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_Get_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_Get_ClientData
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_get_trans are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_get_trans
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_get_vectmode are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_set_vectmode
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_get_vectname are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_get_sitename
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_new_vector are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_new_site
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_select_surf are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_select_surf
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_Set_ClientData are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_Set_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_Set_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_get_wire_color
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_get_drawmode
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_Set_ClientData
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_isosurf_get_drawmode
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GVL2.c GVL_slice_get_drawmode
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_set_trans are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_set_trans
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_get_trans
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_set_vectmode are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c GV_get_vectmode
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_surf_is_selected are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_surf_is_selected
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_unselect_surf are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GP2.c GP_unselect_surf
In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GV2.c clones of GV_vect_exists are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_surf_exists
*****************************************************************
File :grass/trunk/visualization/nviz/src/map_obj.c
*****************************************************************
Function
att_atoi(Begins at: 2110, Ends at:2126)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
delete_obj(Begins at: 951, Ends at:975)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
draw_obj(Begins at: 920, Ends at:944)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
get_att(Begins at: 1552, Ends at:1699)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 30 | *** | MONSTER | 30 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 41 | *** | MONSTER | 41 |
LOC: | 148 | *** | MONSTER | 148 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
get_char_marker(Begins at: 2158, Ends at:2202)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 45 | * | WARNING | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
get_drawmode(Begins at: 844, Ends at:912)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 69 | * | WARNING | 69 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
get_exag_guess(Begins at: 1470, Ends at:1489)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
get_idnum(Begins at: 2072, Ends at:2085)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_int_marker(Begins at: 2208, Ends at:2248)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
get_logical_name(Begins at: 276, Ends at:315)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
get_mask_mode(Begins at: 2020, Ends at:2034)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
get_nozero(Begins at: 1285, Ends at:1319)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 35 | | OK | 35 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
get_res(Begins at: 983, Ends at:1035)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 53 | * | WARNING | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
get_trans(Begins at: 1162, Ends at:1200)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
get_type(Begins at: 2092, Ends at:2104)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_wirecolor(Begins at: 1127, Ends at:1155)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
isosurf(Begins at: 2255, Ends at:2299)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 34 | ** | BABY-MONSTER | 34 |
LOC: | 45 | * | WARNING | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
load_obj(Begins at: 1498, Ends at:1534)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Nget_site_list_cmd(Begins at: 372, Ends at:390)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Nget_surf_list_cmd(Begins at: 322, Ends at:340)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Nget_vect_list_cmd(Begins at: 347, Ends at:365)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Nget_vol_list_cmd(Begins at: 397, Ends at:415)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Nliteral_from_logical_cmd(Begins at: 86, Ends at:189)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 32 | ** | BABY-MONSTER | 32 |
LOC: | 104 | ** | BABY-MONSTER | 104 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Nlogical_from_literal_cmd(Begins at: 196, Ends at:209)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Nmap_obj_cmd(Begins at: 708, Ends at:772)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 28 | *** | MONSTER | 28 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 56 | *** | MONSTER | 56 |
LOC: | 65 | * | WARNING | 65 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Nnew_map_obj_cmd(Begins at: 432, Ends at:698)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 39 | *** | MONSTER | 39 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 80 | *** | MONSTER | 80 |
LOC: | 267 | *** | MONSTER | 267 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
select_surf(Begins at: 1328, Ends at:1355)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
set_att(Begins at: 1711, Ends at:1965)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 33 | *** | MONSTER | 33 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 60 | *** | MONSTER | 60 |
LOC: | 255 | *** | MONSTER | 255 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
set_drawmode(Begins at: 780, Ends at:837)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 13 | * | WARNING | 13 |
LOC: | 58 | * | WARNING | 58 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
set_exag_obj(Begins at: 1440, Ends at:1463)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
set_logical_name(Begins at: 216, Ends at:269)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 54 | * | WARNING | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
set_mask_mode(Begins at: 2042, Ends at:2063)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 22 | | OK | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
set_nozero(Begins at: 1242, Ends at:1278)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
set_res(Begins at: 1042, Ends at:1085)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 44 | * | WARNING | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
set_trans(Begins at: 1207, Ends at:1235)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
set_wirecolor(Begins at: 1092, Ends at:1119)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
slice(Begins at: 2306, Ends at:2345)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | ** | BABY-MONSTER | 15 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 28 | ** | BABY-MONSTER | 28 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
surf_is_selected(Begins at: 1400, Ends at:1432)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
sv_att_atoi(Begins at: 2132, Ends at:2152)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
unselect_surf(Begins at: 1364, Ends at:1392)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
unset_att(Begins at: 1972, Ends at:2013)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 42 | * | WARNING | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Mon Oct 27 09:55:59 EST 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list