[GRASS-QA] GRASS QA: martinl |Box.c cairodriver.h Color.c
Draw_bitmap.c ...| 36 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Thu Sep 4 14:44:50 EDT 2008
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/lib/cairodriver/Box.c
*****************************************************************
Function
Cairo_Box(Begins at: 5, Ends at:12)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cairodriver/cairodriver.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/cairodriver/Color.c
*****************************************************************
Function
Cairo_color(Begins at: 7, Ends at:23)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_lookup_color(Begins at: 25, Ends at:30)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Color.c clones of Cairo_color are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Color.c Cairo_color
*****************************************************************
File :grass/trunk/lib/cairodriver/Draw_bitmap.c
*****************************************************************
Function
Cairo_draw_bitmap(Begins at: 27, Ends at:47)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
fix_surface(Begins at: 3, Ends at:25)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
fix_surface
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Draw_bitmap.c clones of Cairo_draw_bitmap are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Draw_bitmap.c Cairo_draw_bitmap
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Draw_bitmap.c clones of fix_surface are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Draw_bitmap.c fix_surface
*****************************************************************
File :grass/trunk/lib/cairodriver/Draw_line.c
*****************************************************************
Function
Cairo_draw_line(Begins at: 3, Ends at:17)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Draw_line.c clones of Cairo_draw_line are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Draw_line.c Cairo_draw_line
*****************************************************************
File :grass/trunk/lib/cairodriver/Draw_point.c
*****************************************************************
Function
Cairo_draw_point(Begins at: 6, Ends at:15)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cairodriver/Driver.c
*****************************************************************
Function
Cairo_Driver(Begins at: 22, Ends at:57)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 36 | | OK | 36 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
HTML_Driver PNG_Driver
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Driver.c clones of Cairo_Driver are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/psdriver/Driver.c PS_Driver
/var/project-manager/grass/grassSVN/grass/trunk/lib/htmldriver/Driver.c HTML_Driver
/var/project-manager/grass/grassSVN/grass/trunk/lib/pngdriver/Driver.c PNG_Driver
*****************************************************************
File :grass/trunk/lib/cairodriver/Erase.c
*****************************************************************
Function
Cairo_Erase(Begins at: 3, Ends at:14)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Erase.c clones of Cairo_Erase are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Erase.c Cairo_Erase
*****************************************************************
File :grass/trunk/lib/cairodriver/Graph.c
*****************************************************************
Function
Cairo_Graph_close(Begins at: 236, Ends at:250)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_Graph_set(Begins at: 195, Ends at:234)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
ends_with(Begins at: 298, Ends at:305)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
init_cairo(Begins at: 252, Ends at:295)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 44 | * | WARNING | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
init_file(Begins at: 100, Ends at:193)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 25 | ** | BABY-MONSTER | 25 |
LOC: | 94 | ** | BABY-MONSTER | 94 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
init_xlib(Begins at: 45, Ends at:97)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 53 | * | WARNING | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
map_file(Begins at: 307, Ends at:333)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 4 potentially cloned functions:
init_file init_xlib map_file
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Graph.c clones of Cairo_Graph_close are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Graph.c Cairo_Graph_close
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Graph.c clones of init_file are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Graph.c init_file
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Graph.c clones of init_xlib are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Graph.c init_xlib
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Graph.c clones of map_file are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Graph.c map_file
*****************************************************************
File :grass/trunk/lib/cairodriver/Line_width.c
*****************************************************************
Function
Cairo_Line_width(Begins at: 11, Ends at:18)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cairodriver/Poly.c
*****************************************************************
Function
Cairo_Polydots(Begins at: 28, Ends at:36)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Cairo_Polygon(Begins at: 12, Ends at:18)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Cairo_Polyline(Begins at: 20, Ends at:26)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
do_polygon(Begins at: 3, Ends at:10)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cairodriver/Raster.c
*****************************************************************
Function
Cairo_begin_scaled_raster(Begins at: 12, Ends at:49)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 38 | | OK | 38 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Cairo_end_scaled_raster(Begins at: 74, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_scaled_raster(Begins at: 51, Ends at:72)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 22 | | OK | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
Cairo_scaled_raster
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Raster.c clones of Cairo_begin_scaled_raster are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Raster.c Cairo_begin_scaled_raster
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Raster.c clones of Cairo_scaled_raster are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/Raster.c Cairo_scaled_raster
*****************************************************************
File :grass/trunk/lib/cairodriver/read.c
*****************************************************************
Function
cairo_read_image(Begins at: 3, Ends at:39)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/read.c clones of cairo_read_image are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/read.c read_image
*****************************************************************
File :grass/trunk/lib/cairodriver/read_bmp.c
*****************************************************************
Function
cairo_read_bmp(Begins at: 67, Ends at:85)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_2(Begins at: 9, Ends at:16)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_4(Begins at: 18, Ends at:25)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
read_bmp_header(Begins at: 27, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 4 potentially cloned functions:
read_bmp_header read_bmp_header read_bmp_header
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/read_bmp.c clones of cairo_read_bmp are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/read_bmp.c read_bmp
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/read_bmp.c clones of read_bmp_header are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/pngdriver/read_bmp.c read_bmp_header
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/read_bmp.c read_bmp_header
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/pngdriver/read_bmp.c read_bmp_header
*****************************************************************
File :grass/trunk/lib/cairodriver/read_ppm.c
*****************************************************************
Function
cairo_read_ppm(Begins at: 3, Ends at:68)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 66 | * | WARNING | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/read_ppm.c clones of cairo_read_ppm are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/read_ppm.c read_ppm
*****************************************************************
File :grass/trunk/lib/cairodriver/Respond.c
*****************************************************************
Function
Cairo_Respond(Begins at: 4, Ends at:8)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cairodriver/Set_window.c
*****************************************************************
Function
Cairo_Set_window(Begins at: 3, Ends at:10)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cairodriver/Text.c
*****************************************************************
Function
Cairo_draw_text(Begins at: 84, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_font_info(Begins at: 251, Ends at:255)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_font_list(Begins at: 245, Ends at:249)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_set_encoding(Begins at: 217, Ends at:223)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_set_font(Begins at: 205, Ends at:215)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Cairo_text_box(Begins at: 101, Ends at:119)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
convert(Begins at: 13, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 54 | * | WARNING | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
font_list_toy(Begins at: 225, Ends at:243)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
is_toy_font(Begins at: 194, Ends at:203)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
set_font_fc(Begins at: 151, Ends at:174)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
set_font_toy(Begins at: 121, Ends at:147)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
set_matrix(Begins at: 68, Ends at:82)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 7 potentially cloned functions:
which_item GS_setall_drawmode find_rule GS_setall_drawmode which_item GS_setall_drawmode
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Text.c clones of is_toy_font are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.colors/main.c find_rule
/var/project-manager/grass/grassSVN/grass/trunk/display/d.save/main.c which_item
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_setall_drawmode
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.colors/main.c find_rule
/tmp/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_setall_drawmode
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.save/main.c which_item
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/ogsf/GS2.c GS_setall_drawmode
*****************************************************************
File :grass/trunk/lib/cairodriver/write.c
*****************************************************************
Function
cairo_write_image(Begins at: 8, Ends at:43)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 36 | | OK | 36 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/write.c clones of cairo_write_image are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/write.c write_image
*****************************************************************
File :grass/trunk/lib/cairodriver/write_bmp.c
*****************************************************************
Function
cairo_write_bmp(Begins at: 51, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
make_bmp_header(Begins at: 29, Ends at:49)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
put_2(Begins at: 9, Ends at:15)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
put_4(Begins at: 17, Ends at:27)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 7 potentially cloned functions:
make_bmp_header make_bmp_header make_bmp_header put_4 put_4 put_4
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/write_bmp.c clones of cairo_write_bmp are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/write_bmp.c write_bmp
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/write_bmp.c clones of make_bmp_header are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/pngdriver/write_bmp.c make_bmp_header
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/write_bmp.c make_bmp_header
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/pngdriver/write_bmp.c make_bmp_header
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/write_bmp.c clones of put_4 are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/write_bmp.c put_4
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/pngdriver/write_bmp.c put_4
/var/project-manager/grass/grassSVN/grass/trunk/lib/pngdriver/write_bmp.c put_4
*****************************************************************
File :grass/trunk/lib/cairodriver/write_ppm.c
*****************************************************************
Function
cairo_write_ppm(Begins at: 3, Ends at:49)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 47 | * | WARNING | 47 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/write_ppm.c clones of cairo_write_ppm are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/cairodriver/write_ppm.c write_ppm
____________________________________________
Threshold GRASS6 key metrics values at Thu Sep 04 14:57:01 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list