[GRASS-QA] GRASS QA: martinl |vedit.h cats.c select.c | 6 clones | 0 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello martinl,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/branches/develbranch_6/include/vedit.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/vector/vedit/cats.c
*****************************************************************

          Function
Vedit_modify_cats(Begins at: 32, Ends at:101)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      70 |     * |      WARNING |        70 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 1 potentially cloned functions:


In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/vedit/cats.c clones of Vedit_modify_cats are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/vedit/cats.c  Vedit_modify_cats

*****************************************************************
          File :grass/branches/develbranch_6/lib/vector/vedit/select.c
*****************************************************************

          Function
merge_lists(Begins at: 247, Ends at:265)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


select_by_query(Begins at: 134, Ends at:237)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      18 |    ** | BABY-MONSTER |        18 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      23 |    ** | BABY-MONSTER |        23 |
LOC:          |     104 |    ** | BABY-MONSTER |       104 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


Vedit_select_by_query(Begins at: 43, Ends at:125)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |    ** | BABY-MONSTER |        16 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |      21 |     * |      WARNING |        21 |
LOC:          |      83 |     * |      WARNING |        83 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 5 potentially cloned functions:
  merge_lists  merge_lists  select_by_query  Vedit_select_by_query

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/vedit/select.c clones of merge_lists are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.edit/select.c  merge_lists
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/vedit/select.c  merge_lists
          /var/project-manager/grass/grassSVN/grass/trunk/vector/v.edit/select.c  merge_lists

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/vedit/select.c clones of select_by_query are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/vedit/select.c  select_by_query

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/vedit/select.c clones of Vedit_select_by_query are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/vedit/select.c  Vedit_select_by_query

____________________________________________


Threshold GRASS6 key metrics values at Fri Sep 05 12:10:11 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html