[GRASS-QA] GRASS QA: glynn |apply.c execute.c filter.h getfilt.c ...|
1 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 12:20:06 EDT 2008
Hello glynn,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/raster/r.mfilter/apply.c
*****************************************************************
Function
apply_filter(Begins at: 9, Ends at:54)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 46 | * | WARNING | 46 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.mfilter/execute.c
*****************************************************************
Function
execute_filter(Begins at: 6, Ends at:121)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 116 | ** | BABY-MONSTER | 116 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.mfilter/filter.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter/getfilt.c
*****************************************************************
Function
get_filter(Begins at: 6, Ends at:160)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 33 | *** | MONSTER | 33 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 58 | *** | MONSTER | 58 |
LOC: | 155 | *** | MONSTER | 155 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.mfilter/getrow.c
*****************************************************************
Function
getmaprow(Begins at: 9, Ends at:14)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
getrow(Begins at: 16, Ends at:25)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.mfilter/glob.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter/local_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter/main.c
*****************************************************************
Function
main(Begins at: 32, Ends at:140)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 32 | ** | BABY-MONSTER | 32 |
LOC: | 109 | ** | BABY-MONSTER | 109 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.mfilter/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.mfilter.fp/main.c main
*****************************************************************
File :grass/trunk/raster/r.mfilter/perform.c
*****************************************************************
Function
perform_filter(Begins at: 9, Ends at:103)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 36 | ** | BABY-MONSTER | 36 |
LOC: | 95 | ** | BABY-MONSTER | 95 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.mfilter/uppercase.c
*****************************************************************
Function
uppercase(Begins at: 1, Ends at:8)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/apply.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/execute.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/filter.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/getfilt.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/getrow.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/glob.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/local_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/main.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/perform.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.mfilter.fp/uppercase.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 12:25:28 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list