[GRASS-QA] GRASS QA: glynn |write.c | 3 clones | 0 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello glynn,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/lib/vector/Vlib/write.c
*****************************************************************

          Function
delete_dummy(Begins at: 36, Ends at:41)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       6 |       |           OK |         6 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


format(Begins at: 44, Ends at:48)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


rewrite_dummy(Begins at: 30, Ends at:35)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       6 |       |           OK |         6 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Vect_delete_line(Begins at: 205, Ends at:236)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      32 |       |           OK |        32 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Vect_rewrite_line(Begins at: 145, Ends at:171)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Vect_write_line(Begins at: 99, Ends at:125)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


write_dummy(Begins at: 24, Ends at:29)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       6 |       |           OK |         6 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 3 potentially cloned functions:
  Vect_rewrite_line  Vect_write_line

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/write.c clones of Vect_delete_line are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/write.c  Vect_delete_line

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/write.c clones of Vect_rewrite_line are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/write.c  Vect_rewrite_line

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/write.c clones of Vect_write_line are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/write.c  Vect_write_line

____________________________________________


Threshold GRASS6 key metrics values at Fri Sep 05 12:38:28 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html