[GRASS-QA] GRASS QA: glynn |main.c main.c main.c main.c ...| 71
clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 13:07:55 EDT 2008
Hello glynn,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/vector/v.buffer/main.c
*****************************************************************
Function
area_in_buffer(Begins at: 137, Ends at:217)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | *** | MONSTER | 10 |
ParamNBR: | 6 | | OK | 6 |
CalledNBR: | 15 | *** | MONSTER | 15 |
LOC: | 81 | *** | MONSTER | 81 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
input_distance(Begins at: 36, Ends at:130)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | | OK | 16 |
ParamNBR: | 5 | | OK | 5 |
CalledNBR: | 16 | | OK | 16 |
LOC: | 95 | | OK | 95 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 229, Ends at:756)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 65 | * | WARNING | 65 |
ParamNBR: | 2 | ** | BABY-MONSTER | 2 |
CalledNBR: | 192 | * | WARNING | 192 |
LOC: | 528 | * | WARNING | 528 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
stop(Begins at: 219, Ends at:227)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | ** | BABY-MONSTER | 1 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 6 | * | WARNING | 6 |
LOC: | 9 | ** | BABY-MONSTER | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
input_distance
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.buffer/main.c clones of area_in_buffer are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.buffer/main.c area_in_buffer
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.buffer/main.c clones of input_distance are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.buffer/main.c input_distance
*****************************************************************
File :grass/trunk/vector/v.build/main.c
*****************************************************************
Function
main(Begins at: 24, Ends at:167)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 27 | *** | MONSTER | 27 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 47 | *** | MONSTER | 47 |
LOC: | 144 | *** | MONSTER | 144 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.build/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.build/main.c main
*****************************************************************
File :grass/trunk/vector/v.build.polylines/main.c
*****************************************************************
Function
main(Begins at: 84, Ends at:236)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 60 | *** | MONSTER | 60 |
LOC: | 153 | *** | MONSTER | 153 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.build.polylines/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.build.polylines/main.c main
*****************************************************************
File :grass/trunk/vector/v.category/main.c
*****************************************************************
Function
main(Begins at: 48, Ends at:501)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 84 | *** | MONSTER | 84 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 122 | *** | MONSTER | 122 |
LOC: | 454 | *** | MONSTER | 454 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.category/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.category/main.c main
*****************************************************************
File :grass/trunk/vector/v.class/main.c
*****************************************************************
Function
main(Begins at: 26, Ends at:227)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 78 | *** | MONSTER | 78 |
LOC: | 202 | *** | MONSTER | 202 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/vector/v.clean/main.c
*****************************************************************
Function
main(Begins at: 25, Ends at:398)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 62 | *** | MONSTER | 62 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 175 | *** | MONSTER | 175 |
LOC: | 374 | *** | MONSTER | 374 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.clean/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.clean/main.c main
*****************************************************************
File :grass/trunk/vector/v.db.connect/main.c
*****************************************************************
Function
main(Begins at: 31, Ends at:325)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 36 | *** | MONSTER | 36 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 130 | *** | MONSTER | 130 |
LOC: | 295 | *** | MONSTER | 295 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/vector/v.db.select/main.c
*****************************************************************
Function
main(Begins at: 29, Ends at:185)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 22 | *** | MONSTER | 22 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 73 | *** | MONSTER | 73 |
LOC: | 157 | *** | MONSTER | 157 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.db.select/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.db.select/main.c main
*****************************************************************
File :grass/trunk/vector/v.distance/main.c
*****************************************************************
Function
cmp_exist(Begins at: 1189, Ends at:1199)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
cmp_near(Begins at: 1156, Ends at:1166)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
cmp_near_to(Begins at: 1168, Ends at:1186)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 72, Ends at:1153)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 174 | *** | MONSTER | 174 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 340 | *** | MONSTER | 340 |
LOC: | 1082 | *** | MONSTER | 1082 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
print_upload(Begins at: 1204, Ends at:1277)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | *** | MONSTER | 21 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 17 | * | WARNING | 17 |
LOC: | 74 | * | WARNING | 74 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 48 potentially cloned functions:
srch_cat cmp cmp cmp cmp cmpcatkey cmp cmp cmp fcmp dcmp dcmp cmp srch cmp cmp cmpcatkey cmp fcmp dcmp dcmp cmp srch srch_cat cmp_near cmpcat comp_array cmpcat cmpcatkey cmp_cat sort_new cmp_field comp_array cmp_along cmp cmp cmpcat cmpcatkey cmp_cat sort_new cmp_field cmp_along cmp cmp cmpcat cmp_near_to print_upload
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.distance/main.c clones of cmp_exist are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.distance/main.c cmp_exist
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.what.rast/main.c srch_cat
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/cats.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.coin/make_coin.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/db/dbmi_client/copy_tab.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/db/dbmi_client/select.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/db/dbmi_client/select.c cmpcatkey
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/array.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/cats.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.coin/make_coin.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.mapcalc/xmedian.c fcmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.mapcalc/xmedian.c dcmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.mapcalc/xmode.c dcmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extract/extract.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.to.db/update.c srch
/var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_client/copy_tab.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_client/select.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_client/select.c cmpcatkey
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/array.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.mapcalc/xmedian.c fcmp
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.mapcalc/xmedian.c dcmp
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.mapcalc/xmode.c dcmp
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.extract/extract.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.to.db/update.c srch
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.what.rast/main.c srch_cat
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.distance/main.c clones of cmp_near are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.distance/main.c cmp_near
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.reclass/main.c cmpcat
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.random.cells/init.c comp_array
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/db/dbmi_client/select.c cmpcat
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/db/dbmi_client/select.c cmpcatkey
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/cindex.c cmp_cat
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/snap.c sort_new
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/diglib/cindex.c cmp_field
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.random.cells/init.c comp_array
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.lrs/v.lrs.label/main.c cmp_along
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.net.path/path.c cmp
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.overlay/util.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_client/select.c cmpcat
/var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_client/select.c cmpcatkey
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/cindex.c cmp_cat
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/snap.c sort_new
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/cindex.c cmp_field
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.lrs/v.lrs.label/main.c cmp_along
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.net.path/path.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.overlay/util.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.reclass/main.c cmpcat
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.distance/main.c clones of cmp_near_to are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.distance/main.c cmp_near_to
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.distance/main.c clones of print_upload are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.distance/main.c print_upload
*****************************************************************
File :grass/trunk/vector/v.drape/main.c
*****************************************************************
Function
main(Begins at: 37, Ends at:286)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 23 | *** | MONSTER | 23 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 60 | *** | MONSTER | 60 |
LOC: | 250 | *** | MONSTER | 250 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.drape/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.drape/main.c main
*****************************************************************
File :grass/trunk/vector/v.edit/main.c
*****************************************************************
Function
main(Begins at: 23, Ends at:471)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 75 | *** | MONSTER | 75 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 184 | *** | MONSTER | 184 |
LOC: | 449 | *** | MONSTER | 449 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/vector/v.extract/main.c
*****************************************************************
Function
add_cat(Begins at: 38, Ends at:48)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 50, Ends at:413)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 52 | *** | MONSTER | 52 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 135 | *** | MONSTER | 135 |
LOC: | 364 | *** | MONSTER | 364 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
scan_cats(Begins at: 417, Ends at:436)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
main scan_cats
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extract/main.c clones of add_cat are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extract/main.c add_cat
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extract/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extract/main.c main
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extract/main.c clones of scan_cats are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extract/main.c scan_cats
*****************************************************************
File :grass/trunk/vector/v.extrude/main.c
*****************************************************************
Function
extrude(Begins at: 380, Ends at:514)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | ** | BABY-MONSTER | 19 |
ParamNBR: | 11 | *** | MONSTER | 11 |
CalledNBR: | 23 | ** | BABY-MONSTER | 23 |
LOC: | 135 | ** | BABY-MONSTER | 135 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 34, Ends at:356)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 33 | *** | MONSTER | 33 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 127 | *** | MONSTER | 127 |
LOC: | 323 | *** | MONSTER | 323 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
main
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extrude/main.c clones of extrude are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extrude/main.c extrude
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extrude/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extrude/main.c main
*****************************************************************
File :grass/trunk/vector/v.generalize/main.c
*****************************************************************
Function
main(Begins at: 42, Ends at:501)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 65 | *** | MONSTER | 65 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 156 | *** | MONSTER | 156 |
LOC: | 460 | *** | MONSTER | 460 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.generalize/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.generalize/main.c main
*****************************************************************
File :grass/trunk/vector/v.hull/main.c
*****************************************************************
Class
Point(Begins at: 33, Ends at:38)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
cmpPoints(Begins at: 51, Ends at:63)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
convexHull(Begins at: 65, Ends at:128)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 64 | * | WARNING | 64 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
convexHull3d(Begins at: 132, Ends at:161)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
loadSiteCoordinates(Begins at: 164, Ends at:215)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 267, Ends at:380)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 41 | *** | MONSTER | 41 |
LOC: | 114 | ** | BABY-MONSTER | 114 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
outputHull(Begins at: 223, Ends at:265)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 43 | * | WARNING | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
rightTurn(Begins at: 40, Ends at:49)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 9 potentially cloned functions:
candidate_compare candidate_compare convexHull convexHull3d loadSiteCoordinates main outputHull rightTurn
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.hull/main.c clones of cmpPoints are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.hull/main.c cmpPoints
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.label.sa/labels.c candidate_compare
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.label.sa/labels.c candidate_compare
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.hull/main.c clones of convexHull are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.hull/main.c convexHull
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.hull/main.c clones of convexHull3d are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.hull/main.c convexHull3d
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.hull/main.c clones of loadSiteCoordinates are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.hull/main.c loadSiteCoordinates
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.hull/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.hull/main.c main
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.hull/main.c clones of outputHull are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.hull/main.c outputHull
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.hull/main.c clones of rightTurn are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.hull/main.c rightTurn
*****************************************************************
File :grass/trunk/vector/v.info/main.c
*****************************************************************
Function
format_double(Begins at: 337, Ends at:341)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 42, Ends at:333)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | ** | BABY-MONSTER | 19 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 230 | *** | MONSTER | 230 |
LOC: | 292 | *** | MONSTER | 292 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 13:13:17 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list