[GRASS-QA] GRASS QA: neteler |gis.h gisdefs.h closecell.c G.h ...| 57
clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 13:37:17 EDT 2008
Hello neteler,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/include/gis.h
*****************************************************************
Class
Categories(Begins at: 445, Ends at:469)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Cell_head(Begins at: 250, Ends at:272)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Cell_stats(Begins at: 485, Ends at:500)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Cell_stats_node(Begins at: 487, Ends at:493)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Colors(Begins at: 315, Ends at:333)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
FPRange(Begins at: 520, Ends at:525)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
FPReclass(Begins at: 370, Ends at:392)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
FPReclass_table(Begins at: 360, Ends at:366)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Flag(Begins at: 593, Ends at:601)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
GModule(Begins at: 603, Ends at:611)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
G_3dview(Begins at: 530, Ends at:555)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Histogram(Begins at: 502, Ends at:511)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Histogram_list(Begins at: 506, Ends at:510)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
History(Begins at: 471, Ends at:483)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Key_Value(Begins at: 557, Ends at:563)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Option(Begins at: 565, Ends at:591)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 1 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 1 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Quant(Begins at: 402, Ends at:443)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Quant_table(Begins at: 394, Ends at:400)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Range(Begins at: 513, Ends at:518)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Reclass(Begins at: 349, Ends at:358)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
TimeStamp(Begins at: 613, Ends at:617)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
_Color_Info_(Begins at: 288, Ends at:313)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
_Color_Rule_(Begins at: 274, Ends at:286)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/include/gisdefs.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/branches/develbranch_6/lib/gis/closecell.c
*****************************************************************
Function
close_new(Begins at: 159, Ends at:393)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 32 | *** | MONSTER | 32 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 74 | *** | MONSTER | 74 |
LOC: | 235 | *** | MONSTER | 235 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
close_old(Begins at: 124, Ends at:157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 34 | | OK | 34 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_close_cell(Begins at: 79, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_unopen_cell(Begins at: 112, Ends at:122)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__write_fp_format(Begins at: 396, Ends at:425)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 9 potentially cloned functions:
close_old G_unopen_cell G_close_cell G_unopen_cell G_close_cell G_close_cell G_unopen_cell G__write_fp_format
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/closecell.c clones of close_new are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/closecell.c close_new
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/closecell.c clones of close_old are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/closecell.c close_old
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/closecell.c clones of G_close_cell are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/closecell.c G_unopen_cell
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/closecell.c G_close_cell
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/closecell.c G_unopen_cell
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/closecell.c clones of G_unopen_cell are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/closecell.c G_close_cell
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/closecell.c G_close_cell
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/closecell.c G_unopen_cell
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/closecell.c clones of G__write_fp_format are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/closecell.c G__write_fp_format
*****************************************************************
File :grass/branches/develbranch_6/lib/gis/G.h
*****************************************************************
Class
G__(Begins at: 49, Ends at:71)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
fileinfo(Begins at: 17, Ends at:47)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/lib/gis/gdal.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/branches/develbranch_6/lib/gis/get_row.c
*****************************************************************
Function
cell_values_double(Begins at: 312, Ends at:350)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
cell_values_float(Begins at: 270, Ends at:308)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
cell_values_int(Begins at: 223, Ends at:266)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 6 | * | WARNING | 6 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 44 | | OK | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
compute_window_row(Begins at: 38, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | * | WARNING | 4 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
do_reclass_int(Begins at: 69, Ends at:98)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
embed_mask(Begins at: 1010, Ends at:1026)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 2 | ** | BABY-MONSTER | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
embed_nulls(Begins at: 1036, Ends at:1062)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | * | WARNING | 4 |
ParamNBR: | 6 | * | WARNING | 6 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 27 | * | WARNING | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
get_map_row(Begins at: 531, Ends at:572)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 42 | | OK | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
get_map_row_nomask(Begins at: 464, Ends at:508)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 45 | | OK | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
get_map_row_no_reclass(Begins at: 512, Ends at:527)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 6 | * | WARNING | 6 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
get_null_value_row(Begins at: 1028, Ends at:1034)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
get_null_value_row_nomask(Begins at: 915, Ends at:1002)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | | OK | 13 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 15 | | OK | 15 |
LOC: | 88 | | OK | 88 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_c_raster_row(Begins at: 795, Ends at:798)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_c_raster_row_nomask(Begins at: 653, Ends at:656)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_d_raster_row(Begins at: 838, Ends at:841)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_d_raster_row_nomask(Begins at: 693, Ends at:696)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_f_raster_row(Begins at: 818, Ends at:821)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_f_raster_row_nomask(Begins at: 673, Ends at:676)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_map_row(Begins at: 720, Ends at:723)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_map_row_nomask(Begins at: 612, Ends at:615)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_null_value_row(Begins at: 1086, Ends at:1091)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_get_raster_row(Begins at: 768, Ends at:771)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_get_raster_row_nomask(Begins at: 632, Ends at:636)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | * | WARNING | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
open_null_read(Begins at: 849, Ends at:882)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 34 | | OK | 34 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
read_data(Begins at: 204, Ends at:217)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
read_data_compressed(Begins at: 143, Ends at:179)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
read_data_fp_compressed(Begins at: 102, Ends at:120)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
read_data_uncompressed(Begins at: 183, Ends at:198)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
read_null_bits(Begins at: 884, Ends at:913)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 5 | | OK | 5 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
rle_decompress(Begins at: 124, Ends at:141)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
transfer_to_cell_df(Begins at: 423, Ends at:431)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
transfer_to_cell_di(Begins at: 397, Ends at:409)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
transfer_to_cell_fd(Begins at: 445, Ends at:453)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
transfer_to_cell_fi(Begins at: 383, Ends at:395)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
transfer_to_cell_id(Begins at: 435, Ends at:443)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | * | WARNING | 2 |
ParamNBR: | 2 | ** | BABY-MONSTER | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | * | WARNING | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
transfer_to_cell_if(Begins at: 413, Ends at:421)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | * | WARNING | 2 |
ParamNBR: | 2 | ** | BABY-MONSTER | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | * | WARNING | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
transfer_to_cell_XX(Begins at: 370, Ends at:379)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | ** | BABY-MONSTER | 1 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 0 | * | WARNING | 0 |
LOC: | 10 | * | WARNING | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 29 potentially cloned functions:
cell_values_float cell_values_double cell_values_double cell_values_float cell_values_double cell_values_int compute_window_row do_reclass_int embed_mask embed_nulls get_map_row get_map_row_nomask get_map_row_no_reclass get_null_value_row_nomask open_null_read read_data read_data_compressed read_data_fp_compressed read_data_uncompressed read_null_bits rle_decompress transfer_to_cell_fi transfer_to_cell_fi transfer_to_cell_di transfer_to_cell_di transfer_to_cell_fi transfer_to_cell_di transfer_to_cell_XX
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of cell_values_double are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c cell_values_float
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c cell_values_float
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c cell_values_double
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of cell_values_float are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c cell_values_double
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c cell_values_float
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c cell_values_double
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of cell_values_int are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c cell_values_int
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of compute_window_row are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c compute_window_row
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of do_reclass_int are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c do_reclass_int
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of embed_mask are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c embed_mask
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of embed_nulls are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c embed_nulls
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of get_map_row are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c get_map_row
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of get_map_row_nomask are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c get_map_row_nomask
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of get_map_row_no_reclass are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c get_map_row_no_reclass
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of get_null_value_row_nomask are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c get_null_value_row_nomask
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of open_null_read are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c open_null_read
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of read_data are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c read_data
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of read_data_compressed are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c read_data_compressed
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of read_data_fp_compressed are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c read_data_fp_compressed
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of read_data_uncompressed are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c read_data_uncompressed
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of read_null_bits are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c read_null_bits
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of rle_decompress are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c rle_decompress
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of transfer_to_cell_di are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c transfer_to_cell_fi
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c transfer_to_cell_fi
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c transfer_to_cell_di
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of transfer_to_cell_fi are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c transfer_to_cell_di
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c transfer_to_cell_fi
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c transfer_to_cell_di
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/get_row.c clones of transfer_to_cell_XX are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_row.c transfer_to_cell_XX
*****************************************************************
File :grass/branches/develbranch_6/lib/gis/opencell.c
*****************************************************************
Function
allocate_compress_buf(Begins at: 770, Ends at:787)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
clean_check_raster_name(Begins at: 555, Ends at:584)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_cellvalue_format(Begins at: 502, Ends at:511)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_get_raster_map_type(Begins at: 999, Ends at:1004)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_new(Begins at: 453, Ends at:460)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_new_random(Begins at: 462, Ends at:469)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_new_uncompressed(Begins at: 471, Ends at:478)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_old(Begins at: 178, Ends at:198)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_fp_cell_new(Begins at: 513, Ends at:533)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_fp_cell_new_uncompressed(Begins at: 535, Ends at:553)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_raster_new(Begins at: 1060, Ends at:1067)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_raster_new_uncompressed(Begins at: 1069, Ends at:1076)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_raster_map_is_fp(Begins at: 910, Ends at:925)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_raster_map_type(Begins at: 945, Ends at:948)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_raster_map_type2(Begins at: 966, Ends at:985)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_set_cell_format(Begins at: 488, Ends at:500)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_set_fp_type(Begins at: 879, Ends at:894)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_set_quant_rules(Begins at: 1093, Ends at:1119)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_want_histogram(Begins at: 480, Ends at:485)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__check_fp_type(Begins at: 1008, Ends at:1058)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 51 | * | WARNING | 51 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G__open_cell_old(Begins at: 231, Ends at:423)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 23 | *** | MONSTER | 23 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 47 | *** | MONSTER | 47 |
LOC: | 193 | *** | MONSTER | 193 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
G__open_raster_new(Begins at: 587, Ends at:761)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 62 | *** | MONSTER | 62 |
LOC: | 175 | *** | MONSTER | 175 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
G__reallocate_mask_buf(Begins at: 831, Ends at:845)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__reallocate_null_buf(Begins at: 813, Ends at:826)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__reallocate_temp_buf(Begins at: 850, Ends at:864)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__reallocate_work_buf(Begins at: 792, Ends at:807)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
new_fileinfo(Begins at: 114, Ends at:136)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 19 potentially cloned functions:
clean_check_raster_name G_cellvalue_format G__reallocate_null_buf G__reallocate_temp_buf G__reallocate_null_buf G__reallocate_mask_buf G__reallocate_temp_buf G__reallocate_mask_buf G__reallocate_temp_buf G__reallocate_null_buf G__reallocate_mask_buf G__reallocate_temp_buf G__reallocate_null_buf G__reallocate_mask_buf G__reallocate_null_buf G__reallocate_mask_buf G__reallocate_temp_buf G__reallocate_work_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of allocate_compress_buf are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c allocate_compress_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of clean_check_raster_name are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c clean_check_raster_name
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G_cellvalue_format are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G_cellvalue_format
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G__reallocate_mask_buf are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_null_buf
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_temp_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_null_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_mask_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_temp_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G__reallocate_null_buf are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_mask_buf
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_temp_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_null_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_mask_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_temp_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G__reallocate_temp_buf are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_null_buf
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_mask_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_null_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_mask_buf
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_temp_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G__reallocate_work_buf are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/opencell.c G__reallocate_work_buf
*****************************************************************
File :grass/branches/develbranch_6/raster/r.external/main.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 13:42:40 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list