[GRASS-QA] GRASS QA: martinl |open.c | 9 clones | 0 monsters |0
warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 13:44:27 EDT 2008
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/lib/vector/Vlib/open.c
*****************************************************************
Function
fatal_error(Begins at: 59, Ends at:71)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
format(Begins at: 38, Ends at:42)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
open_old_dummy(Begins at: 32, Ends at:35)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_coor_info(Begins at: 611, Ends at:649)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_maptype_info(Begins at: 659, Ends at:676)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_open_new(Begins at: 517, Ends at:600)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 43 | *** | MONSTER | 43 |
LOC: | 84 | * | WARNING | 84 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_open_old(Begins at: 413, Ends at:416)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_open_old_head(Begins at: 467, Ends at:471)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_open_spatial_index(Begins at: 771, Ends at:836)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 66 | * | WARNING | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_open_topo(Begins at: 689, Ends at:761)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 73 | * | WARNING | 73 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_open_update(Begins at: 430, Ends at:452)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_open_update_head(Begins at: 485, Ends at:505)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_set_open_level(Begins at: 96, Ends at:107)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect__open_old(Begins at: 124, Ends at:399)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 31 | *** | MONSTER | 31 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 102 | *** | MONSTER | 102 |
LOC: | 276 | *** | MONSTER | 276 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 9 potentially cloned functions:
Vect_coor_info Vect_maptype_info Vect_open_new Vect_open_spatial_index Vect_open_topo Vect_open_update Vect_open_update_head Vect_set_open_level
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of fatal_error are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c fatal_error
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_coor_info are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_coor_info
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_maptype_info are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_maptype_info
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_open_new are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_new
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_open_spatial_index are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_spatial_index
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_open_topo are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_topo
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_open_update are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_update
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_open_update_head are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_update_head
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/open.c clones of Vect_set_open_level are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_set_open_level
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 13:49:50 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list