[GRASS-QA] GRASS QA: martinl |6s.cpp AerosolModel.cpp AtmosModel.cpp
computations.cpp ...| 32 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 14:13:46 EDT 2008
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/imagery/i.atcorr/6s.cpp
*****************************************************************
Function
compute(Begins at: 238, Ends at:612)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 31 | *** | MONSTER | 31 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 34 | ** | BABY-MONSTER | 34 |
LOC: | 375 | *** | MONSTER | 375 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
init_6S(Begins at: 39, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 17 | * | WARNING | 17 |
LOC: | 61 | * | WARNING | 61 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
pre_compute_h(Begins at: 136, Ends at:149)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
pre_compute_hv(Begins at: 103, Ends at:117)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
pre_compute_v(Begins at: 120, Ends at:133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
printOutput(Begins at: 152, Ends at:236)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 50 | *** | MONSTER | 50 |
LOC: | 85 | * | WARNING | 85 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
init_6S pre_compute_h pre_compute_hv pre_compute_v printOutput
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/6s.cpp clones of compute are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/6s.cpp compute
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/6s.cpp clones of init_6S are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/6s.cpp init_6S
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/6s.cpp clones of pre_compute_h are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/6s.cpp pre_compute_h
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/6s.cpp clones of pre_compute_hv are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/6s.cpp pre_compute_hv
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/6s.cpp clones of pre_compute_v are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/6s.cpp pre_compute_v
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/6s.cpp clones of printOutput are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/6s.cpp printOutput
*****************************************************************
File :grass/branches/develbranch_6/imagery/i.atcorr/AerosolModel.cpp
*****************************************************************
Class
AerosolModel(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 119 | 126 | 1 | 91 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 119 | 126 | 1 | 91 |
+------------+--------+--------+--------+--------+--------+--------+
Method
aeroso(Begins at: 497, Ends at:780)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 48 | *** | MONSTER | 48 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 284 | *** | MONSTER | 284 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
bbm(Begins at: 15, Ends at:18)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
bdm(Begins at: 9, Ends at:12)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dust(Begins at: 27, Ends at:30)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
load(Begins at: 400, Ends at:436)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
ocea(Begins at: 39, Ends at:42)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse(Begins at: 782, Ends at:971)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 34 | | OK | 34 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 48 | | OK | 48 |
LOC: | 190 | | OK | 190 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Parse(Begins at: 1160, Ends at:1165)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | ** | BABY-MONSTER | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | *** | MONSTER | 1 |
LOC: | 6 | *** | MONSTER | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
print(Begins at: 984, Ends at:1158)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | | OK | 19 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 111 | | OK | 111 |
LOC: | 175 | | OK | 175 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
print132(Begins at: 974, Ends at:981)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | * | WARNING | 5 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
save(Begins at: 440, Ends at:474)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 18 | | OK | 18 |
LOC: | 35 | | OK | 35 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
soot(Begins at: 45, Ends at:48)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
stm(Begins at: 21, Ends at:24)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/imagery/i.atcorr/AtmosModel.cpp
*****************************************************************
Class
AtmosModel(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 30 | 57 | 0 | 36 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 30 | 57 | 0 | 36 |
+------------+--------+--------+--------+--------+--------+--------+
Method
midsum(Begins at: 59, Ends at:110)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
midwin(Begins at: 112, Ends at:163)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
parse(Begins at: 325, Ends at:366)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | | OK | 13 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 15 | *** | MONSTER | 15 |
LOC: | 42 | * | WARNING | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Parse(Begins at: 460, Ends at:465)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | * | WARNING | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
print(Begins at: 369, Ends at:458)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 67 | | OK | 67 |
LOC: | 90 | * | WARNING | 90 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
subsum(Begins at: 165, Ends at:216)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
subwin(Begins at: 218, Ends at:269)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
tropic(Begins at: 4, Ends at:57)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 54 | | OK | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp
*****************************************************************
Class
OpticalAtmosProperties(Begins at: 15, Ends at:25)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
atmref(Begins at: 1361, Ends at:1413)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 53 | * | WARNING | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
chand(Begins at: 1275, Ends at:1350)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 76 | * | WARNING | 76 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
csalbr(Begins at: 1436, Ends at:1440)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
discom(Begins at: 1591, Ends at:1675)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 85 | * | WARNING | 85 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
discre(Begins at: 165, Ends at:209)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 45 | * | WARNING | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
enviro(Begins at: 1730, Ends at:1819)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 90 | * | WARNING | 90 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
fintexp1(Begins at: 1416, Ends at:1428)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
fintexp3(Begins at: 1430, Ends at:1433)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
odrayl(Begins at: 29, Ends at:51)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
scatra(Begins at: 1442, Ends at:1587)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 45 | *** | MONSTER | 45 |
LOC: | 146 | *** | MONSTER | 146 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
specinterp(Begins at: 1682, Ends at:1718)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
trunca(Begins at: 63, Ends at:154)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | ** | BABY-MONSTER | 17 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 92 | ** | BABY-MONSTER | 92 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 10 potentially cloned functions:
chand discom discre enviro fintexp1 odrayl scatra specinterp trunca
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of atmref are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp atmref
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of chand are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp chand
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of discom are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp discom
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of discre are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp discre
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of enviro are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp enviro
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of fintexp1 are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp fintexp1
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of odrayl are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp odrayl
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of scatra are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp scatra
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of specinterp are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp specinterp
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/computations.cpp clones of trunca are:
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/computations.cpp trunca
*****************************************************************
File :grass/branches/develbranch_6/imagery/i.atcorr/GeomCond.cpp
*****************************************************************
Class
GeomCond(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 47 | 162 | 0 | 45 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 47 | 162 | 0 | 45 |
+------------+--------+--------+--------+--------+--------+--------+
Method
day_number(Begins at: 87, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
landsat(Begins at: 60, Ends at:67)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse(Begins at: 308, Ends at:399)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | | OK | 16 |
ParamNBR: | 0 | * | WARNING | 0 |
CalledNBR: | 22 | *** | MONSTER | 22 |
LOC: | 92 | * | WARNING | 92 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Parse(Begins at: 470, Ends at:475)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | * | WARNING | 1 |
ParamNBR: | 0 | * | WARNING | 0 |
CalledNBR: | 1 | * | WARNING | 1 |
LOC: | 6 | * | WARNING | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
posnoa(Begins at: 254, Ends at:306)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 5 | | OK | 5 |
CalledNBR: | 38 | | OK | 38 |
LOC: | 53 | | OK | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
posobs(Begins at: 165, Ends at:252)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | | OK | 9 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 15 | ** | BABY-MONSTER | 15 |
LOC: | 88 | * | WARNING | 88 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
possol(Begins at: 75, Ends at:85)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | *** | MONSTER | 3 |
LOC: | 11 | * | WARNING | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
pos_fft(Begins at: 104, Ends at:157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 28 | | OK | 28 |
LOC: | 54 | | OK | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
print(Begins at: 402, Ends at:468)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 57 | | OK | 57 |
LOC: | 67 | | OK | 67 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/imagery/i.atcorr/Iwave.cpp
*****************************************************************
Class
IWave(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 197 | 74 | 0 | 120 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 197 | 74 | 0 | 120 |
+------------+--------+--------+--------+--------+--------+--------+
Method
avhrr(Begins at: 144, Ends at:607)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 35 | *** | MONSTER | 35 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 464 | *** | MONSTER | 464 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
equivwl(Begins at: 1687, Ends at:1704)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
etmplus(Begins at: 1311, Ends at:1451)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | ** | BABY-MONSTER | 17 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 141 | *** | MONSTER | 141 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
goes_east(Begins at: 69, Ends at:104)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 36 | | OK | 36 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
goes_west(Begins at: 106, Ends at:142)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
hrv(Begins at: 609, Ends at:763)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | ** | BABY-MONSTER | 19 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 155 | *** | MONSTER | 155 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
mas(Begins at: 989, Ends at:1122)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 23 | *** | MONSTER | 23 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 134 | ** | BABY-MONSTER | 134 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
meteo(Begins at: 10, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 57 | * | WARNING | 57 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
modis(Begins at: 1124, Ends at:1207)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | ** | BABY-MONSTER | 17 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 84 | * | WARNING | 84 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
mss(Begins at: 898, Ends at:987)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 90 | * | WARNING | 90 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
parse(Begins at: 1706, Ends at:1763)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | ** | BABY-MONSTER | 19 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 23 | | OK | 23 |
LOC: | 58 | ** | BABY-MONSTER | 58 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Parse(Begins at: 1868, Ends at:1873)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 1 | *** | MONSTER | 1 |
LOC: | 6 | ** | BABY-MONSTER | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
polder(Begins at: 1209, Ends at:1309)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | | OK | 19 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 101 | *** | MONSTER | 101 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
print(Begins at: 1766, Ends at:1866)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | ** | BABY-MONSTER | 4 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 117 | | OK | 117 |
LOC: | 101 | ** | BABY-MONSTER | 101 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
solirr(Begins at: 1453, Ends at:1685)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 233 | | OK | 233 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/imagery/i.atcorr/main.cpp
*****************************************************************
Class
IntPair(Begins at: 202, Ends at:216)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 5 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 5 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------+
Method
IntPair(Begins at: 207, Ends at:207)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 1 | | OK | 1 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
operator<(Begins at: 209, Ends at:215)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Class
Options(Begins at: 41, Ends at:60)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Position(Begins at: 171, Ends at:177)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 2 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 2 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------+
Method
Position(Begins at: 175, Ends at:175)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 1 | | OK | 1 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
valid(Begins at: 176, Ends at:176)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 1 | | OK | 1 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Class
ScaleRange(Begins at: 62, Ends at:66)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
TICache(Begins at: 123, Ends at:153)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 8 | 4 | 0 | 2 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 8 | 4 | 0 | 2 |
+------------+--------+--------+--------+--------+--------+--------+
Method
add(Begins at: 147, Ends at:152)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get(Begins at: 146, Ends at:146)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 1 | | OK | 1 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
search(Begins at: 135, Ends at:144)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TICache(Begins at: 134, Ends at:134)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 1 | | OK | 1 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Class
TIMap(Begins at: 159, Ends at:199)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 8 | 10 | 0 | 4 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 8 | 10 | 0 | 4 |
+------------+--------+--------+--------+--------+--------+--------+
Method
add(Begins at: 193, Ends at:198)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 2 |
CalledNBR: | 1 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
get(Begins at: 191, Ends at:191)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 0 |
LOC: | 1 | | OK | 1 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
search(Begins at: 180, Ends at:189)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 1 |
CalledNBR: | 2 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIMap(Begins at: 179, Ends at:179)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 1 | | OK | 1 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Function
adjust_region(Begins at: 88, Ends at:97)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
copy_colors(Begins at: 392, Ends at:398)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
define_module(Begins at: 402, Ends at:426)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
define_options(Begins at: 430, Ends at:499)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 533, Ends at:619)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 35 | ** | BABY-MONSTER | 35 |
LOC: | 87 | * | WARNING | 87 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
optimize_va(Begins at: 222, Ends at:242)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
process_raster(Begins at: 259, Ends at:387)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 23 | *** | MONSTER | 23 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 42 | *** | MONSTER | 42 |
LOC: | 129 | ** | BABY-MONSTER | 129 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
read_scale(Begins at: 502, Ends at:530)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
round_c(Begins at: 101, Ends at:107)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
write_fp_to_cell(Begins at: 111, Ends at:120)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 16 potentially cloned functions:
adjust_region define_module define_module define_options define_options main main optimize_va optimize_va process_raster process_raster read_scale read_scale write_fp_to_cell write_fp_to_cell
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of adjust_region are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp adjust_region
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp adjust_region
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of define_module are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp define_module
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp define_module
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of define_options are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp define_options
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp define_options
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of main are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp main
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp main
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of optimize_va are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp optimize_va
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp optimize_va
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of process_raster are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp process_raster
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp process_raster
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of read_scale are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp read_scale
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp read_scale
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/imagery/i.atcorr/main.cpp clones of write_fp_to_cell are:
/tmp/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp write_fp_to_cell
/var/project-manager/grass/grassSVN/grass/trunk/imagery/i.atcorr/main.cpp write_fp_to_cell
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 14:19:08 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list