[GRASS-QA] GRASS QA: rmatev |dgraph.c e_intersect.c vlib_buffer.c
dgraph.c ...| 2 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Sep 10 12:34:16 EDT 2008
Hello rmatev,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass-addons/vector/v.buffer2/dgraph.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass-addons/vector/v.buffer2/e_intersect.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass-addons/vector/v.buffer2/vlib_buffer.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass-addons/vector/v.parallel2/dgraph.c
*****************************************************************
Class
intersection_point(Begins at: 280, Ends at:284)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
seg_intersection(Begins at: 286, Ends at:290)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
seg_intersection_list(Begins at: 292, Ends at:296)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
seg_intersections(Begins at: 298, Ends at:305)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
add_ipoint(Begins at: 356, Ends at:376)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | *** | MONSTER | 3 |
ParamNBR: | 6 | *** | MONSTER | 6 |
CalledNBR: | 7 | *** | MONSTER | 7 |
LOC: | 21 | *** | MONSTER | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
add_ipoint1(Begins at: 339, Ends at:353)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 4 | *** | MONSTER | 4 |
CalledNBR: | 2 | *** | MONSTER | 2 |
LOC: | 15 | *** | MONSTER | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
compare(Begins at: 403, Ends at:415)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | *** | MONSTER | 3 |
ParamNBR: | 2 | *** | MONSTER | 2 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 13 | *** | MONSTER | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
create_si_struct(Begins at: 307, Ends at:324)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 1 | *** | MONSTER | 1 |
CalledNBR: | 6 | *** | MONSTER | 6 |
LOC: | 18 | *** | MONSTER | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
destroy_si_struct(Begins at: 326, Ends at:336)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 1 | *** | MONSTER | 1 |
CalledNBR: | 4 | *** | MONSTER | 4 |
LOC: | 11 | *** | MONSTER | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
find_all_intersections(Begins at: 418, Ends at:522)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | *** | MONSTER | 18 |
ParamNBR: | 1 | *** | MONSTER | 1 |
CalledNBR: | 32 | *** | MONSTER | 32 |
LOC: | 105 | *** | MONSTER | 105 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
pg_addedge(Begins at: 585, Ends at:613)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | *** | MONSTER | 4 |
ParamNBR: | 3 | *** | MONSTER | 3 |
CalledNBR: | 6 | *** | MONSTER | 6 |
LOC: | 29 | *** | MONSTER | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
pg_addedge1(Begins at: 576, Ends at:583)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 2 | *** | MONSTER | 2 |
CalledNBR: | 2 | *** | MONSTER | 2 |
LOC: | 8 | *** | MONSTER | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
pg_create(Begins at: 615, Ends at:688)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | *** | MONSTER | 9 |
ParamNBR: | 1 | *** | MONSTER | 1 |
CalledNBR: | 10 | *** | MONSTER | 10 |
LOC: | 74 | *** | MONSTER | 74 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
pg_create_struct(Begins at: 526, Ends at:540)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 2 | *** | MONSTER | 2 |
CalledNBR: | 7 | *** | MONSTER | 7 |
LOC: | 15 | *** | MONSTER | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
pg_destroy_struct(Begins at: 542, Ends at:552)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 1 | *** | MONSTER | 1 |
CalledNBR: | 5 | *** | MONSTER | 5 |
LOC: | 11 | *** | MONSTER | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
pg_existsedge(Begins at: 555, Ends at:573)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | *** | MONSTER | 4 |
ParamNBR: | 3 | *** | MONSTER | 3 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 19 | *** | MONSTER | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
segment_intersection_2d(Begins at: 20, Ends at:278)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 40 | *** | MONSTER | 40 |
ParamNBR: | 13 | *** | MONSTER | 13 |
CalledNBR: | 70 | *** | MONSTER | 70 |
LOC: | 259 | *** | MONSTER | 259 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
sort_intersection_list(Begins at: 378, Ends at:401)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | *** | MONSTER | 5 |
ParamNBR: | 1 | *** | MONSTER | 1 |
CalledNBR: | 2 | *** | MONSTER | 2 |
LOC: | 24 | *** | MONSTER | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass-addons/vector/v.parallel2/e_intersect.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass-addons/vector/v.parallel2/vlib_buffer.c
*****************************************************************
Function
add_line_to_array(Begins at: 687, Ends at:695)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 5 | *** | MONSTER | 5 |
CalledNBR: | 2 | *** | MONSTER | 2 |
LOC: | 9 | *** | MONSTER | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
angular_tolerance(Begins at: 127, Ends at:135)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 3 | *** | MONSTER | 3 |
CalledNBR: | 3 | *** | MONSTER | 3 |
LOC: | 9 | *** | MONSTER | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
convolution_line(Begins at: 297, Ends at:425)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | *** | MONSTER | 16 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 30 | *** | MONSTER | 30 |
LOC: | 129 | *** | MONSTER | 129 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
elliptic_tangent(Begins at: 77, Ends at:92)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 7 | *** | MONSTER | 7 |
CalledNBR: | 5 | *** | MONSTER | 5 |
LOC: | 16 | *** | MONSTER | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
elliptic_transform(Begins at: 52, Ends at:69)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 7 | *** | MONSTER | 7 |
CalledNBR: | 2 | *** | MONSTER | 2 |
LOC: | 18 | *** | MONSTER | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
extract_contour(Begins at: 432, Ends at:528)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | *** | MONSTER | 12 |
ParamNBR: | 6 | *** | MONSTER | 6 |
CalledNBR: | 9 | *** | MONSTER | 9 |
LOC: | 97 | *** | MONSTER | 97 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
extract_inner_contour(Begins at: 588, Ends at:615)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | *** | MONSTER | 5 |
ParamNBR: | 3 | *** | MONSTER | 3 |
CalledNBR: | 3 | *** | MONSTER | 3 |
LOC: | 28 | *** | MONSTER | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
extract_outer_contour(Begins at: 540, Ends at:579)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | *** | MONSTER | 6 |
ParamNBR: | 3 | *** | MONSTER | 3 |
CalledNBR: | 2 | *** | MONSTER | 2 |
LOC: | 40 | *** | MONSTER | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
line_coefficients(Begins at: 98, Ends at:103)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 7 | *** | MONSTER | 7 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 6 | *** | MONSTER | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
line_intersection(Begins at: 110, Ends at:125)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | *** | MONSTER | 3 |
ParamNBR: | 8 | *** | MONSTER | 8 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 16 | *** | MONSTER | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
norm_vector(Begins at: 27, Ends at:40)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 6 | *** | MONSTER | 6 |
CalledNBR: | 1 | *** | MONSTER | 1 |
LOC: | 14 | *** | MONSTER | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
parallel_line(Begins at: 149, Ends at:294)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | *** | MONSTER | 20 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 30 | *** | MONSTER | 30 |
LOC: | 146 | *** | MONSTER | 146 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
parallel_line_b(Begins at: 697, Ends at:794)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | *** | MONSTER | 9 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 35 | *** | MONSTER | 35 |
LOC: | 98 | *** | MONSTER | 98 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
point_in_buf(Begins at: 622, Ends at:684)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | *** | MONSTER | 7 |
ParamNBR: | 6 | *** | MONSTER | 6 |
CalledNBR: | 5 | *** | MONSTER | 5 |
LOC: | 63 | *** | MONSTER | 63 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
rotate_vector(Begins at: 42, Ends at:46)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 6 | *** | MONSTER | 6 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 5 | *** | MONSTER | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_line_buffer(Begins at: 830, Ends at:926)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | *** | MONSTER | 10 |
ParamNBR: | 4 | *** | MONSTER | 4 |
CalledNBR: | 26 | *** | MONSTER | 26 |
LOC: | 97 | *** | MONSTER | 97 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_line_parallel2(Begins at: 806, Ends at:817)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 8 | *** | MONSTER | 8 |
CalledNBR: | 2 | *** | MONSTER | 2 |
LOC: | 12 | *** | MONSTER | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
vect
In /var/project-manager/grass/grassSVN/grass-addons/vector/v.parallel2/vlib_buffer.c clones of norm_vector are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/Vlib/buffer.c vect
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/buffer.c vect
____________________________________________
Threshold GRASS6 key metrics values at Wed Sep 10 12:40:43 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 0 | 0 | 0 |
ParamNBR: | 0 | 0 | 0 |
CalledNBR: | 0 | 0 | 0 |
LOC: | 0 | 0 | 0 |
----------------------+-----------+-----------+-----------+
Please visite our web site on your project at :http://web.soccerlab.polymtl.ca/project-manager/index.html
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list