[GRASS-QA] GRASS QA: hamish |decorate.h distance.h do_scalebar.c get_scalebar.c ...| no clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Wed Sep 10 12:39:20 EDT 2008


Hello hamish,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/ps/ps.map/decorate.h
*****************************************************************

          Class
scalebar(Begins at: 7, Ends at:18)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------+



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/ps/ps.map/distance.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/trunk/ps/ps.map/do_scalebar.c
*****************************************************************

          Function
do_scalebar(Begins at: 20, Ends at:182)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |   *** |      MONSTER |        14 |
ParamNBR:     |       1 |   *** |      MONSTER |         1 |
CalledNBR:    |      49 |   *** |      MONSTER |        49 |
LOC:          |     163 |   *** |      MONSTER |       163 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


nice_number(Begins at: 185, Ends at:199)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |   *** |      MONSTER |         4 |
ParamNBR:     |       1 |   *** |      MONSTER |         1 |
CalledNBR:    |       4 |   *** |      MONSTER |         4 |
LOC:          |      15 |   *** |      MONSTER |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/ps/ps.map/get_scalebar.c
*****************************************************************

          Function
read_scalebar(Begins at: 25, Ends at:119)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |   *** |      MONSTER |        19 |
ParamNBR:     |       1 |   *** |      MONSTER |         1 |
CalledNBR:    |      18 |   *** |      MONSTER |        18 |
LOC:          |      95 |   *** |      MONSTER |        95 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/ps/ps.map/map_setup.c
*****************************************************************

          Function
map_setup(Begins at: 14, Ends at:122)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |   *** |      MONSTER |         8 |
ParamNBR:     |       1 |   *** |      MONSTER |         1 |
CalledNBR:    |       9 |   *** |      MONSTER |         9 |
LOC:          |     109 |   *** |      MONSTER |       109 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/ps/ps.map/scale.c
*****************************************************************

          Function
do_scale(Begins at: 34, Ends at:134)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |   *** |      MONSTER |        16 |
ParamNBR:     |       1 |   *** |      MONSTER |         1 |
CalledNBR:    |      29 |   *** |      MONSTER |        29 |
LOC:          |     101 |   *** |      MONSTER |       101 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


OOPS(Begins at: 136, Ends at:139)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |   *** |      MONSTER |         1 |
ParamNBR:     |       1 |   *** |      MONSTER |         1 |
CalledNBR:    |       2 |   *** |      MONSTER |         2 |
LOC:          |       4 |   *** |      MONSTER |         4 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


scale(Begins at: 26, Ends at:32)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |   *** |      MONSTER |         1 |
ParamNBR:     |       1 |   *** |      MONSTER |         1 |
CalledNBR:    |       1 |   *** |      MONSTER |         1 |
LOC:          |       7 |   *** |      MONSTER |         7 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold GRASS6 key metrics values at Wed Sep 10 12:45:47 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         0 |         0 |         0 |
ParamNBR:             |         0 |         0 |         0 |
CalledNBR:            |         0 |         0 |         0 |
LOC:                  |         0 |         0 |         0 |
----------------------+-----------+-----------+-----------+



Please visite our web site on your project at :http://web.soccerlab.polymtl.ca/project-manager/index.html
Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html 



More information about the grass-qa mailing list