[GRASS-QA] GRASS QA: glynn |tif_swab.c main.c gui.c | 11 clones | 0
monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Sep 10 23:43:58 EDT 2008
Hello glynn,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/raster/r.out.bin/tif_swab.c
*****************************************************************
Function
TIFFGetBitRevTable(Begins at: 215, Ends at:218)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIFFReverseBits(Begins at: 220, Ends at:235)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIFFReverseBits(Begins at: 225, Ends at:240)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIFFSwabArrayOfDouble(Begins at: 122, Ends at:134)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIFFSwabArrayOfDouble(Begins at: 127, Ends at:139)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIFFSwabArrayOfLong(Begins at: 89, Ends at:105)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIFFSwabArrayOfLong(Begins at: 94, Ends at:110)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
TIFFSwabArrayOfShort(Begins at: 72, Ends at:85)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 10 potentially cloned functions:
TIFFReverseBits TIFFReverseBits TIFFReverseBits TIFFSwabArrayOfDouble TIFFSwabArrayOfDouble TIFFSwabArrayOfDouble TIFFSwabArrayOfDouble TIFFSwabArrayOfShort TIFFSwabArrayOfShort
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c clones of TIFFReverseBits are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFReverseBits
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFReverseBits
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c clones of TIFFReverseBits are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFReverseBits
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFReverseBits
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c clones of TIFFSwabArrayOfDouble are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFSwabArrayOfDouble
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFSwabArrayOfDouble
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c clones of TIFFSwabArrayOfDouble are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFSwabArrayOfDouble
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFSwabArrayOfDouble
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c clones of TIFFSwabArrayOfShort are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFSwabArrayOfShort
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.bin/tif_swab.c TIFFSwabArrayOfShort
*****************************************************************
File :grass/trunk/raster/r.out.tiff/main.c
*****************************************************************
Function
main(Begins at: 70, Ends at:379)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 35 | *** | MONSTER | 35 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 99 | *** | MONSTER | 99 |
LOC: | 310 | *** | MONSTER | 310 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
write_tfw(Begins at: 382, Ends at:406)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.tiff/main.c clones of write_tfw are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.tiff/r.out.tiff.c write_tfw
*****************************************************************
File :grass/trunk/visualization/xganim/gui.c
*****************************************************************
Function
exit_callback(Begins at: 386, Ends at:389)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
faster_callback(Begins at: 375, Ends at:379)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
loop_callback(Begins at: 349, Ends at:355)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
make_buttons(Begins at: 55, Ends at:194)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 60 | *** | MONSTER | 60 |
LOC: | 140 | ** | BABY-MONSTER | 140 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
names_callback(Begins at: 381, Ends at:384)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
play_callback(Begins at: 341, Ends at:347)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
rewind_callback(Begins at: 304, Ends at:311)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
rplay_callback(Begins at: 313, Ends at:320)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
set_buttons_pixmap(Begins at: 196, Ends at:302)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 40 | *** | MONSTER | 40 |
LOC: | 107 | ** | BABY-MONSTER | 107 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
slower_callback(Begins at: 365, Ends at:373)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
stepb_callback(Begins at: 322, Ends at:327)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
stepf_callback(Begins at: 334, Ends at:339)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
stop_callback(Begins at: 329, Ends at:332)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
swing_callback(Begins at: 357, Ends at:363)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold GRASS6 key metrics values at Wed Sep 10 23:50:32 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Please visite our web site on your project at :http://web.soccerlab.polymtl.ca/project-manager/index.html
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list