[GRASS-QA] GRASS QA: martinl |do_areas.c do_lines.c main.c raster.c
...| 1 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Feb 3 11:34:18 EST 2009
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/vector/v.to.rast/do_areas.c
*****************************************************************
Function
compare(Begins at: 136, Ends at:146)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
do_areas(Begins at: 22, Ends at:84)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 63 | * | WARNING | 63 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
sort_areas(Begins at: 87, Ends at:133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 17 | * | WARNING | 17 |
LOC: | 47 | * | WARNING | 47 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.to.rast/do_areas.c clones of compare are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/histogram.c cmp
*****************************************************************
File :grass/branches/develbranch_6/vector/v.to.rast/do_lines.c
*****************************************************************
Function
deg_angle(Begins at: 156, Ends at:174)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
do_lines(Begins at: 16, Ends at:129)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 26 | *** | MONSTER | 26 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 24 | ** | BABY-MONSTER | 24 |
LOC: | 114 | ** | BABY-MONSTER | 114 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
plot_line(Begins at: 132, Ends at:144)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
plot_points(Begins at: 177, Ends at:184)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
v2angle(Begins at: 148, Ends at:153)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/vector/v.to.rast/main.c
*****************************************************************
Function
main(Begins at: 27, Ends at:145)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 42 | *** | MONSTER | 42 |
LOC: | 119 | ** | BABY-MONSTER | 119 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/vector/v.to.rast/raster.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/branches/develbranch_6/vector/v.to.rast/vect2rast.c
*****************************************************************
Function
vect_to_rast(Begins at: 9, Ends at:232)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 39 | *** | MONSTER | 39 |
ParamNBR: | 11 | *** | MONSTER | 11 |
CalledNBR: | 77 | *** | MONSTER | 77 |
LOC: | 224 | *** | MONSTER | 224 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Tue Feb 03 11:57:52 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list