[GRASS-QA] GRASS QA: neteler |execute.c | 5 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Tue Feb 3 14:47:00 EST 2009


Hello neteler,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/db/db.execute/execute.c
*****************************************************************

          Function
get_stmt(Begins at: 136, Ends at:168)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      33 |       |           OK |        33 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


main(Begins at: 37, Ends at:91)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      25 |    ** | BABY-MONSTER |        25 |
LOC:          |      55 |     * |      WARNING |        55 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


parse_command_line(Begins at: 94, Ends at:133)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      15 |     * |      WARNING |        15 |
LOC:          |      40 |       |           OK |        40 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


stmt_is_empty(Begins at: 171, Ends at:176)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       6 |       |           OK |         6 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 5 potentially cloned functions:
  main  main  parse_command_line  parse_command_line

In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c clones of get_stmt are:
          /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c  get_stmt

In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c clones of main are:
          /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c  main
          /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c  main

In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c clones of parse_command_line are:
          /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c  parse_command_line
          /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c  parse_command_line

____________________________________________


Threshold grass key metrics values at Tue Feb 03 15:10:35 EST 2009 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list