[GRASS-QA] GRASS QA: martinl |columns.c main.c connect.c main.c ...|
64 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Feb 3 14:52:50 EST 2009
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/db/db.columns/columns.c
*****************************************************************
Function
main(Begins at: 33, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 34 | | OK | 34 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 69, Ends at:101)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.columns/main.c
*****************************************************************
Function
main(Begins at: 33, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 34 | | OK | 34 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 69, Ends at:101)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 4 potentially cloned functions:
main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.columns/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/columns.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.columns/columns.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.columns/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/columns.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.columns/columns.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.connect/connect.c
*****************************************************************
Function
main(Begins at: 30, Ends at:174)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 39 | *** | MONSTER | 39 |
LOC: | 145 | *** | MONSTER | 145 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.connect/main.c
*****************************************************************
Function
main(Begins at: 30, Ends at:174)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 39 | *** | MONSTER | 39 |
LOC: | 145 | *** | MONSTER | 145 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 2 potentially cloned functions:
main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.connect/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/connect.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.connect/connect.c main
*****************************************************************
File :grass/trunk/db/db.copy/copy.c
*****************************************************************
Function
main(Begins at: 23, Ends at:129)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 41 | *** | MONSTER | 41 |
LOC: | 107 | ** | BABY-MONSTER | 107 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.copy/main.c
*****************************************************************
Function
main(Begins at: 23, Ends at:129)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 41 | *** | MONSTER | 41 |
LOC: | 107 | ** | BABY-MONSTER | 107 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 2 potentially cloned functions:
main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.copy/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/copy.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.copy/copy.c main
*****************************************************************
File :grass/trunk/db/db.createdb/createdb.c
*****************************************************************
Function
main(Begins at: 33, Ends at:51)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse_command_line(Begins at: 54, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.createdb/main.c
*****************************************************************
Function
main(Begins at: 33, Ends at:51)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse_command_line(Begins at: 54, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 10 potentially cloned functions:
main main main main parse_command_line parse_command_line parse_command_line parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/createdb.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/base/dropdb.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/createdb.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/dropdb.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/main.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/createdb.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/base/dropdb.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/createdb.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/dropdb.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/main.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.databases/databases.c
*****************************************************************
Function
main(Begins at: 34, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 69, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 31 | | OK | 31 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.databases/main.c
*****************************************************************
Function
main(Begins at: 34, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 69, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 31 | | OK | 31 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 4 potentially cloned functions:
main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.databases/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/databases.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.databases/databases.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.databases/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/databases.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.databases/databases.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.describe/describe.c
*****************************************************************
Function
main(Begins at: 38, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 32 | ** | BABY-MONSTER | 32 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
parse_command_line(Begins at: 92, Ends at:135)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 44 | * | WARNING | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.describe/main.c
*****************************************************************
Function
main(Begins at: 38, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 32 | ** | BABY-MONSTER | 32 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
parse_command_line(Begins at: 92, Ends at:135)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 44 | * | WARNING | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file has 4 potentially cloned functions:
main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.describe/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/describe.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.describe/describe.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.describe/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/describe.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.describe/describe.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.drivers/drivers.c
*****************************************************************
Function
main(Begins at: 33, Ends at:53)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse_command_line(Begins at: 56, Ends at:81)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.drivers/main.c
*****************************************************************
Function
main(Begins at: 33, Ends at:53)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse_command_line(Begins at: 56, Ends at:81)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 4 potentially cloned functions:
main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.drivers/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/drivers.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.drivers/drivers.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.drivers/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/drivers.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.drivers/drivers.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.dropdb/dropdb.c
*****************************************************************
Function
main(Begins at: 33, Ends at:51)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse_command_line(Begins at: 54, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.dropdb/main.c
*****************************************************************
Function
main(Begins at: 33, Ends at:51)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
parse_command_line(Begins at: 54, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 10 potentially cloned functions:
main main main main parse_command_line parse_command_line parse_command_line parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/createdb.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/base/dropdb.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/createdb.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/main.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/dropdb.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/createdb.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/base/dropdb.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/createdb.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.createdb/main.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.dropdb/dropdb.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.droptable/droptable.c
*****************************************************************
Function
main(Begins at: 33, Ends at:57)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 60, Ends at:87)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.droptable/main.c
*****************************************************************
Function
main(Begins at: 33, Ends at:57)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 60, Ends at:87)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 4 potentially cloned functions:
main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.droptable/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/droptable.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.droptable/droptable.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.droptable/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/droptable.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.droptable/droptable.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.execute/execute.c
*****************************************************************
Function
get_stmt(Begins at: 136, Ends at:168)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
main(Begins at: 37, Ends at:91)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 25 | ** | BABY-MONSTER | 25 |
LOC: | 55 | * | WARNING | 55 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
parse_command_line(Begins at: 94, Ends at:133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
stmt_is_empty(Begins at: 171, Ends at:176)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 5 potentially cloned functions:
main main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c clones of get_stmt are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c get_stmt
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.execute/main.c
*****************************************************************
Function
get_stmt(Begins at: 136, Ends at:163)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 37, Ends at:91)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 25 | ** | BABY-MONSTER | 25 |
LOC: | 55 | * | WARNING | 55 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
parse_command_line(Begins at: 94, Ends at:133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
stmt_is_empty(Begins at: 166, Ends at:171)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 4 potentially cloned functions:
main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.select/main.c
*****************************************************************
Function
get_stmt(Begins at: 269, Ends at:288)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 38, Ends at:91)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 24 | ** | BABY-MONSTER | 24 |
LOC: | 54 | * | WARNING | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
parse_command_line(Begins at: 165, Ends at:266)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 38 | *** | MONSTER | 38 |
LOC: | 102 | ** | BABY-MONSTER | 102 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
sel(Begins at: 94, Ends at:162)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 25 | ** | BABY-MONSTER | 25 |
LOC: | 69 | * | WARNING | 69 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
stmt_is_empty(Begins at: 291, Ends at:296)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 7 potentially cloned functions:
get_stmt main main parse_command_line sel sel
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.select/main.c clones of get_stmt are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/select.c get_stmt
/var/project-manager/grass/grassSVN/grass/trunk/db/db.select/select.c get_stmt
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.select/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/select.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.select/select.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.select/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/db.select/select.c parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.select/main.c clones of sel are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/select.c sel
/var/project-manager/grass/grassSVN/grass/trunk/db/db.select/select.c sel
*****************************************************************
File :grass/trunk/db/db.select/select.c
*****************************************************************
Function
get_stmt(Begins at: 269, Ends at:288)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 38, Ends at:91)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 24 | ** | BABY-MONSTER | 24 |
LOC: | 54 | * | WARNING | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
parse_command_line(Begins at: 165, Ends at:266)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 38 | *** | MONSTER | 38 |
LOC: | 102 | ** | BABY-MONSTER | 102 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
sel(Begins at: 94, Ends at:162)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 25 | ** | BABY-MONSTER | 25 |
LOC: | 69 | * | WARNING | 69 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
stmt_is_empty(Begins at: 291, Ends at:296)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/db/db.tables/main.c
*****************************************************************
Function
main(Begins at: 34, Ends at:63)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 66, Ends at:104)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 4 potentially cloned functions:
main parse_command_line parse_command_line
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.tables/main.c clones of main are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/tables.c main
/var/project-manager/grass/grassSVN/grass/trunk/db/db.tables/tables.c main
In /var/project-manager/grass/grassSVN/grass/trunk/db/db.tables/main.c clones of parse_command_line are:
/var/project-manager/grass/grassSVN/grass/trunk/db/base/tables.c parse_command_line
/var/project-manager/grass/grassSVN/grass/trunk/db/db.tables/tables.c parse_command_line
*****************************************************************
File :grass/trunk/db/db.tables/tables.c
*****************************************************************
Function
main(Begins at: 34, Ends at:63)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
parse_command_line(Begins at: 66, Ends at:104)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Tue Feb 03 15:16:26 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list