[GRASS-QA] GRASS QA: martinl |update.c | 11 clones | 0 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello martinl,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/vector/v.to.db/update.c
*****************************************************************

          Function
srch(Begins at: 239, Ends at:249)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


update(Begins at: 9, Ends at:237)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      56 |   *** |      MONSTER |        56 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      50 |   *** |      MONSTER |        50 |
LOC:          |     229 |   *** |      MONSTER |       229 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 11 potentially cloned functions:
  cmp  cmp  cmp  cmp  fcmp  dcmp  dcmp  cmp_exist  cmp  srch_cat

In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.to.db/update.c clones of srch are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_client/copy_tab.c  cmp
          /var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_client/select.c  cmp
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/array.c  cmp
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/cats.c  cmp
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.coin/make_coin.c  cmp
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.mapcalc/xmedian.c  fcmp
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.mapcalc/xmedian.c  dcmp
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.mapcalc/xmode.c  dcmp
          /var/project-manager/grass/grassSVN/grass/trunk/vector/v.distance/main.c  cmp_exist
          /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extract/extract.c  cmp
          /var/project-manager/grass/grassSVN/grass/trunk/vector/v.what.rast/main.c  srch_cat

____________________________________________


Threshold grass key metrics values at Tue Feb 03 15:42:18 EST 2009 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html