[GRASS-QA] GRASS QA: hamish |driver.c patch.c patch.h | 6 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Fri Feb 6 12:01:31 EST 2009


Hello hamish,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/raster/r.le/r.le.patch/driver.c
*****************************************************************

          Function
fopen0(Begins at: 438, Ends at:452)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      15 |       |           OK |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


fopen1(Begins at: 458, Ends at:482)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      10 |     * |      WARNING |        10 |
LOC:          |      25 |       |           OK |        25 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


fopen2(Begins at: 487, Ends at:509)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      23 |       |           OK |        23 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


free_para(Begins at: 2434, Ends at:2454)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      21 |       |           OK |        21 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


get_para(Begins at: 2330, Ends at:2424)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      29 |    ** | BABY-MONSTER |        29 |
LOC:          |      95 |    ** | BABY-MONSTER |        95 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


meter(Begins at: 2286, Ends at:2324)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      39 |       |           OK |        39 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


mv_driver(Begins at: 515, Ends at:2222)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |     480 |   *** |      MONSTER |       480 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |     759 |   *** |      MONSTER |       759 |
LOC:          |    1708 |   *** |      MONSTER |      1708 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


open_files(Begins at: 139, Ends at:431)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      52 |   *** |      MONSTER |        52 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |     160 |   *** |      MONSTER |       160 |
LOC:          |     293 |   *** |      MONSTER |       293 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


patch_fore(Begins at: 66, Ends at:131)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      22 |     * |      WARNING |        22 |
LOC:          |      66 |     * |      WARNING |        66 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


read_line(Begins at: 2540, Ends at:2578)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      39 |       |           OK |        39 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


read_mwind(Begins at: 2250, Ends at:2278)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      29 |       |           OK |        29 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


read_para(Begins at: 2464, Ends at:2532)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      69 |     * |      WARNING |        69 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


run_clip(Begins at: 2738, Ends at:2796)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      59 |     * |      WARNING |        59 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


set_colors(Begins at: 2232, Ends at:2242)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


unit_driver(Begins at: 2588, Ends at:2729)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      30 |   *** |      MONSTER |        30 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      51 |   *** |      MONSTER |        51 |
LOC:          |     142 |   *** |      MONSTER |       142 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


whole_reg_driver(Begins at: 2803, Ends at:2881)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |    ** | BABY-MONSTER |        16 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      14 |     * |      WARNING |        14 |
LOC:          |      79 |     * |      WARNING |        79 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 6 potentially cloned functions:
  fopen2  fopen3  meter2  read_mwind  set_colors

In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of fopen1 are:
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c  fopen1

In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of fopen2 are:
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c  fopen2
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c  fopen3

In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of meter are:
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c  meter2

In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of read_mwind are:
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c  read_mwind

In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of set_colors are:
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c  set_colors

*****************************************************************
          File :grass/trunk/raster/r.le/r.le.patch/patch.c
*****************************************************************

          Function
df_att(Begins at: 327, Ends at:366)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      40 |       |           OK |        40 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


df_boundary(Begins at: 1344, Ends at:1397)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      54 |     * |      WARNING |        54 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


df_core(Begins at: 461, Ends at:567)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      15 |    ** | BABY-MONSTER |        15 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      33 |    ** | BABY-MONSTER |        33 |
LOC:          |     107 |    ** | BABY-MONSTER |       107 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


df_patch(Begins at: 41, Ends at:318)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      68 |   *** |      MONSTER |        68 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |     107 |   *** |      MONSTER |       107 |
LOC:          |     278 |   *** |      MONSTER |       278 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


df_perim(Begins at: 1407, Ends at:1505)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      15 |    ** | BABY-MONSTER |        15 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      15 |     * |      WARNING |        15 |
LOC:          |      99 |    ** | BABY-MONSTER |        99 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


df_shape(Begins at: 914, Ends at:1074)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      22 |   *** |      MONSTER |        22 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      52 |   *** |      MONSTER |        52 |
LOC:          |     161 |   *** |      MONSTER |       161 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


df_size(Begins at: 727, Ends at:799)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      17 |     * |      WARNING |        17 |
LOC:          |      73 |     * |      WARNING |        73 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


eu_d(Begins at: 2445, Ends at:2448)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       4 |       |           OK |         4 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


in_group(Begins at: 1591, Ends at:1638)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       3 |       |           OK |         3 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      48 |       |           OK |        48 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


index_coh(Begins at: 1649, Ends at:1665)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |     * |      WARNING |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      17 |     * |      WARNING |        17 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


m_att(Begins at: 1676, Ends at:1806)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |     * |      WARNING |        21 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |     131 |       |           OK |       131 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


m_boundary(Begins at: 2265, Ends at:2342)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |   *** |      MONSTER |        10 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      78 |    ** | BABY-MONSTER |        78 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


m_core(Begins at: 1944, Ends at:2119)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      32 |     * |      WARNING |        32 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |     176 |     * |      WARNING |       176 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


m_perim(Begins at: 2352, Ends at:2441)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |   *** |      MONSTER |        16 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      90 |   *** |      MONSTER |        90 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


m_shape(Begins at: 2130, Ends at:2254)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      24 |    ** | BABY-MONSTER |        24 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |     125 |     * |      WARNING |       125 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


m_size(Begins at: 1814, Ends at:1934)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |   *** |      MONSTER |        19 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |     121 |    ** | BABY-MONSTER |       121 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


mv_patch(Begins at: 1517, Ends at:1554)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |    ** | BABY-MONSTER |        11 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      38 |    ** | BABY-MONSTER |        38 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


recl_coh(Begins at: 1566, Ends at:1580)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      15 |       |           OK |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


save_att(Begins at: 375, Ends at:452)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       8 |    ** | BABY-MONSTER |         8 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      78 |     * |      WARNING |        78 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


save_core(Begins at: 577, Ends at:718)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      26 |   *** |      MONSTER |        26 |
ParamNBR:     |      13 |   *** |      MONSTER |        13 |
CalledNBR:    |      23 |    ** | BABY-MONSTER |        23 |
LOC:          |     142 |   *** |      MONSTER |       142 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


save_shape(Begins at: 1085, Ends at:1332)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      45 |   *** |      MONSTER |        45 |
ParamNBR:     |      19 |   *** |      MONSTER |        19 |
CalledNBR:    |      36 |    ** | BABY-MONSTER |        36 |
LOC:          |     248 |   *** |      MONSTER |       248 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


save_size(Begins at: 809, Ends at:904)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |    ** | BABY-MONSTER |        16 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      96 |    ** | BABY-MONSTER |        96 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/raster/r.le/r.le.patch/patch.h
*****************************************************************

          Class
CHOICE(Begins at: 79, Ends at:86)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------+



Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Fri Feb 06 12:25:44 EST 2009 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list