[GRASS-QA] GRASS QA: neteler |user.h user3.c user4.c | 42 clones | 0
monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Feb 24 15:21:38 EST 2009
Hello neteler,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/vector/v.vol.rst/user.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/branches/develbranch_6/vector/v.vol.rst/user3.c
*****************************************************************
Function
COGRR1(Begins at: 219, Ends at:654)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 74 | *** | MONSTER | 74 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 59 | *** | MONSTER | 59 |
LOC: | 436 | *** | MONSTER | 436 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
POINT(Begins at: 659, Ends at:775)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | ** | BABY-MONSTER | 15 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 117 | ** | BABY-MONSTER | 117 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
secpar_loop(Begins at: 49, Ends at:214)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 35 | *** | MONSTER | 35 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 18 | * | WARNING | 18 |
LOC: | 166 | *** | MONSTER | 166 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/branches/develbranch_6/vector/v.vol.rst/user4.c
*****************************************************************
Function
LINEQS(Begins at: 353, Ends at:493)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 141 | *** | MONSTER | 141 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
amax1(Begins at: 110, Ends at:121)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
amin1(Begins at: 125, Ends at:136)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
clean_fatal_error(Begins at: 47, Ends at:78)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 32 | | OK | 32 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
crs(Begins at: 164, Ends at:204)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
crsd(Begins at: 209, Ends at:253)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 45 | * | WARNING | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
crsdd(Begins at: 301, Ends at:343)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 43 | * | WARNING | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
crsdr2(Begins at: 255, Ends at:299)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 45 | * | WARNING | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
erfr(Begins at: 140, Ends at:160)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
max1(Begins at: 96, Ends at:107)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
min1(Begins at: 82, Ends at:93)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 42 potentially cloned functions:
amax1 amin1 amax1 amin1 min max min1 max1 amin1 min1 amax1 amin1 amax1 amin1 min max min1 max1 amax1 crsdr2 crsd min1 amax1 amin1 amax1 amin1 min max min1 amax1 amin1 min1 amax1 amin1 amax1 amin1 min max max1 amax1 amin1
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c clones of amax1 are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c min1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c max
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c min1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c max1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c amin1
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c clones of amin1 are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c min1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c max
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c min1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c max1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c amax1
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c clones of crsd are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c crsdr2
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c clones of crsdr2 are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c crsd
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c clones of max1 are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c min1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c max
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c min1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c amin1
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c clones of min1 are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c min1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/rst/interp_float/minmax.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/simwe/simlib/input.c max
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c max1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c amax1
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.vol.rst/user4.c amin1
____________________________________________
Threshold grass key metrics values at Tue Feb 24 15:25:17 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list