soccerlab.info at gmail.com soccerlab.info at gmail.com
Mon Jan 5 12:36:40 EST 2009

```Hello hcho,

here's a report on your recent GRASS-SVN change :

ANALYSIS

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      25 |   *** |      MONSTER |        25 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      21 |     * |      WARNING |        21 |
LOC:          |     120 |    ** | BABY-MONSTER |       120 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |    ** | BABY-MONSTER |        16 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      15 |     * |      WARNING |        15 |
LOC:          |      81 |     * |      WARNING |        81 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      67 |     * |      WARNING |        67 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      18 |    ** | BABY-MONSTER |        18 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      14 |     * |      WARNING |        14 |
LOC:          |      81 |     * |      WARNING |        81 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      20 |    ** | BABY-MONSTER |        20 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      19 |     * |      WARNING |        19 |
LOC:          |     109 |    ** | BABY-MONSTER |       109 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |      64 |     * |      WARNING |        64 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      44 |   *** |      MONSTER |        44 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      39 |   *** |      MONSTER |        39 |
LOC:          |     246 |   *** |      MONSTER |       246 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

write_pnts(Begins at: 254, Ends at:288)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      35 |       |           OK |        35 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      25 |   *** |      MONSTER |        25 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      15 |     * |      WARNING |        15 |
LOC:          |     115 |    ** | BABY-MONSTER |       115 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
File :grass/trunk/vector/v.in.dxf/dxf_to_vect.c
*****************************************************************

Function
check_ext(Begins at: 154, Ends at:170)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      17 |       |           OK |        17 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

dxf_to_vect(Begins at: 15, Ends at:152)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      37 |   *** |      MONSTER |        37 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      47 |   *** |      MONSTER |        47 |
LOC:          |     138 |    ** | BABY-MONSTER |       138 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      21 |       |           OK |        21 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

set_entity(Begins at: 172, Ends at:179)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

Clone analysis:
This file does not contain cloned functions

____________________________________________

Threshold grass key metrics values at Mon Jan 05 12:53:55 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning   | middle    | extrem    |
| limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+

Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
OK : Nothing to say at all
*  : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function

Conclusion interpretation :
CORRECT     : if all metrics are situated before warning limits
WARNING     : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS    : if 1 to more metrics are in the extreme limits

_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory