[GRASS-QA] GRASS QA: glynn |gsd_img_mpeg.c | 7 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Fri Jan 9 16:07:44 EST 2009


Hello glynn,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/lib/ogsf/gsd_img_mpeg.c
*****************************************************************

          Function
add_video_stream(Begins at: 55, Ends at:103)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      49 |     * |      WARNING |        49 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


alloc_picture(Begins at: 115, Ends at:138)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      24 |       |           OK |        24 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


close_video(Begins at: 264, Ends at:274)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


gsd_close_mpeg(Begins at: 421, Ends at:450)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      30 |       |           OK |        30 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


gsd_init_mpeg(Begins at: 286, Ends at:365)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      27 |    ** | BABY-MONSTER |        27 |
LOC:          |      80 |     * |      WARNING |        80 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


gsd_write_mpegframe(Begins at: 374, Ends at:414)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      41 |       |           OK |        41 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


open_video(Begins at: 146, Ends at:196)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      51 |     * |      WARNING |        51 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


write_video_frame(Begins at: 204, Ends at:256)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      53 |     * |      WARNING |        53 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 7 potentially cloned functions:
  alloc_picture  close_video  gsd_close_mpeg  gsd_init_mpeg  gsd_write_mpegframe  open_video

In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c clones of add_video_stream are:
          /tmp/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c  add_video_stream

In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c clones of alloc_picture are:
          /tmp/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c  alloc_picture

In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c clones of close_video are:
          /tmp/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c  close_video

In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c clones of gsd_close_mpeg are:
          /tmp/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c  gsd_close_mpeg

In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c clones of gsd_init_mpeg are:
          /tmp/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c  gsd_init_mpeg

In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c clones of gsd_write_mpegframe are:
          /tmp/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c  gsd_write_mpegframe

In /var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c clones of open_video are:
          /tmp/grassSVN/grass/trunk/lib/ogsf/gsd_img_mpeg.c  open_video

____________________________________________


Threshold grass key metrics values at Fri Jan 09 16:25:55 EST 2009 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list