[GRASS-QA] GRASS QA: martinl |gisdefs.h Rast.h adj_cellhd.c
align_window.c ...| no clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Jun 30 14:33:21 EDT 2009
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/include/gisdefs.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/include/Rast.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/gis/adj_cellhd.c
*****************************************************************
Function
G_adjust_Cell_head(Begins at: 43, Ends at:164)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | *** | MONSTER | 21 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 122 | ** | BABY-MONSTER | 122 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
G_adjust_Cell_head3(Begins at: 194, Ends at:359)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 33 | *** | MONSTER | 33 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 166 | *** | MONSTER | 166 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/gis/align_window.c
*****************************************************************
Function
G_align_window(Begins at: 41, Ends at:75)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 13 | * | WARNING | 13 |
LOC: | 35 | | OK | 35 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/gis/get_window.c
*****************************************************************
Function
G__get_window(Begins at: 126, Ends at:156)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 31 | | OK | 31 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_get_default_window(Begins at: 115, Ends at:124)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | * | WARNING | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | * | WARNING | 4 |
LOC: | 10 | * | WARNING | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
G_get_window(Begins at: 47, Ends at:100)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 19 | | OK | 19 |
LOC: | 54 | | OK | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/gis/rd_cellhd.c
*****************************************************************
Function
G__read_Cell_head(Begins at: 44, Ends at:77)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 34 | | OK | 34 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__read_Cell_head_array(Begins at: 80, Ends at:387)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 98 | | OK | 98 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 211 | * | WARNING | 211 |
LOC: | 308 | | OK | 308 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
error(Begins at: 424, Ends at:434)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | *** | MONSTER | 2 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 4 | *** | MONSTER | 4 |
LOC: | 11 | *** | MONSTER | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
scan_double(Begins at: 416, Ends at:422)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
scan_int(Begins at: 408, Ends at:414)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
scan_item(Begins at: 389, Ends at:406)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/gis/set_window.c
*****************************************************************
Function
G_get_set_window(Begins at: 30, Ends at:36)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_set_window(Begins at: 49, Ends at:152)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 104 | ** | BABY-MONSTER | 104 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/raster/adj_cellhd.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/raster/get_cellhd.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/raster/rd_cellhd.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
____________________________________________
Threshold grass key metrics values at Tue Jun 30 14:21:11 EDT 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list