[GRASS-QA] GRASS QA: martinl |interact.c his.c signature.c main.c
...| no clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Jun 30 17:11:36 EDT 2009
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/display/d.colors/interact.c
*****************************************************************
Function
interact(Begins at: 19, Ends at:280)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 62 | *** | MONSTER | 62 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 52 | *** | MONSTER | 52 |
LOC: | 262 | *** | MONSTER | 262 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
save_colors(Begins at: 317, Ends at:331)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
shift_color(Begins at: 282, Ends at:290)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
yes(Begins at: 292, Ends at:315)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/display/d.his/his.c
*****************************************************************
Function
HIS_to_RGB(Begins at: 20, Ends at:62)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | | OK | 9 |
ParamNBR: | 8 | | OK | 8 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
make_gray_scale(Begins at: 64, Ends at:74)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | * | WARNING | 2 |
ParamNBR: | 1 | ** | BABY-MONSTER | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 11 | * | WARNING | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/imagery/i.class/signature.c
*****************************************************************
Function
display_signature(Begins at: 255, Ends at:316)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 25 | ** | BABY-MONSTER | 25 |
LOC: | 62 | * | WARNING | 62 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
done(Begins at: 245, Ends at:248)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dont_save(Begins at: 382, Ends at:385)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
have_signature(Begins at: 325, Ends at:328)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
init_sig_routines(Begins at: 39, Ends at:59)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
prepare_signature(Begins at: 67, Ends at:154)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | ** | BABY-MONSTER | 17 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 88 | * | WARNING | 88 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
save_signature(Begins at: 338, Ends at:351)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
show_signature(Begins at: 172, Ends at:243)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 72 | * | WARNING | 72 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
write_signatures(Begins at: 394, Ends at:403)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
yes_save(Begins at: 353, Ends at:379)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/imagery/i.maxlik/main.c
*****************************************************************
Function
main(Begins at: 29, Ends at:184)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 74 | *** | MONSTER | 74 |
LOC: | 156 | *** | MONSTER | 156 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/include/raster.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/raster/color_init.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/raster/color_set.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.external/main.c
*****************************************************************
Class
band_info(Begins at: 35, Ends at:43)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
check_projection(Begins at: 72, Ends at:184)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | ** | BABY-MONSTER | 19 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 46 | *** | MONSTER | 46 |
LOC: | 113 | ** | BABY-MONSTER | 113 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
create_map(Begins at: 402, Ends at:440)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
list_formats(Begins at: 45, Ends at:70)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 442, Ends at:565)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 51 | *** | MONSTER | 51 |
LOC: | 124 | ** | BABY-MONSTER | 124 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
make_cell(Begins at: 347, Ends at:365)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
make_link(Begins at: 367, Ends at:400)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 17 | * | WARNING | 17 |
LOC: | 34 | | OK | 34 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
query_band(Begins at: 260, Ends at:345)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | ** | BABY-MONSTER | 15 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 86 | * | WARNING | 86 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
setup_window(Begins at: 186, Ends at:232)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 47 | * | WARNING | 47 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
update_default_window(Begins at: 234, Ends at:258)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.his/his.c
*****************************************************************
Function
HIS_to_RGB(Begins at: 20, Ends at:62)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | | OK | 9 |
ParamNBR: | 8 | | OK | 8 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
make_gray_scale(Begins at: 64, Ends at:74)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | * | WARNING | 2 |
ParamNBR: | 1 | ** | BABY-MONSTER | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 11 | * | WARNING | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.in.gdal/main.c
*****************************************************************
Function
ImportBand(Begins at: 642, Ends at:922)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 42 | *** | MONSTER | 42 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 87 | *** | MONSTER | 87 |
LOC: | 281 | *** | MONSTER | 281 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
SetupReprojector(Begins at: 585, Ends at:634)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | *** | MONSTER | 6 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 21 | *** | MONSTER | 21 |
LOC: | 50 | *** | MONSTER | 50 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
main(Begins at: 49, Ends at:578)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 55 | * | WARNING | 55 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 196 | * | WARNING | 196 |
LOC: | 530 | * | WARNING | 530 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.patch/support.c
*****************************************************************
Function
support(Begins at: 13, Ends at:69)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 18 | * | WARNING | 18 |
LOC: | 57 | * | WARNING | 57 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.watershed/ram/close_maps2.c
*****************************************************************
Function
close_array_seg(Begins at: 4, Ends at:141)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 32 | *** | MONSTER | 32 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 38 | *** | MONSTER | 38 |
LOC: | 138 | ** | BABY-MONSTER | 138 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.watershed/seg/close_maps2.c
*****************************************************************
Function
close_array_seg(Begins at: 4, Ends at:112)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 25 | *** | MONSTER | 25 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 29 | ** | BABY-MONSTER | 29 |
LOC: | 109 | ** | BABY-MONSTER | 109 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Tue Jun 30 16:59:23 EDT 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list