[GRASS-QA] GRASS QA: mmetz |geom.c global.h main.c main.c ...| 3
clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Mar 10 10:04:10 EDT 2009
Hello mmetz,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/vector/v.in.ogr/geom.c
*****************************************************************
Function
centroid(Begins at: 30, Ends at:157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | ** | BABY-MONSTER | 18 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 42 | *** | MONSTER | 42 |
LOC: | 128 | ** | BABY-MONSTER | 128 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
geom(Begins at: 160, Ends at:351)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 28 | *** | MONSTER | 28 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 73 | *** | MONSTER | 73 |
LOC: | 192 | *** | MONSTER | 192 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/vector/v.in.ogr/global.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/vector/v.in.ogr/main.c
*****************************************************************
Function
main(Begins at: 47, Ends at:1133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 115 | *** | MONSTER | 115 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 422 | *** | MONSTER | 422 |
LOC: | 1087 | *** | MONSTER | 1087 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/vector/v.net.iso/main.c
*****************************************************************
Function
main(Begins at: 44, Ends at:538)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 58 | *** | MONSTER | 58 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 139 | *** | MONSTER | 139 |
LOC: | 495 | *** | MONSTER | 495 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/vector/v.net.salesman/main.c
*****************************************************************
Function
add_city(Begins at: 49, Ends at:70)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 22 | | OK | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
cmp(Begins at: 391, Ends at:403)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
cnode(Begins at: 44, Ends at:47)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 73, Ends at:389)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 39 | *** | MONSTER | 39 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 122 | *** | MONSTER | 122 |
LOC: | 317 | *** | MONSTER | 317 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 3 potentially cloned functions:
cmp cmp
In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.net.salesman/main.c clones of cmp are:
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.lrs/v.lrs.label/main.c cmp_along
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.net.path/path.c cmp
/var/project-manager/grass/grassSVN/grass/trunk/vector/v.net.steiner/main.c cmp
____________________________________________
Threshold grass key metrics values at Tue Mar 10 09:10:34 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list