[GRASS-QA] GRASS QA: mmetz |map.c | no clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Sat Mar 21 05:15:57 EDT 2009
Hello mmetz,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/lib/vector/Vlib/map.c
*****************************************************************
Function
Vect_copy(Begins at: 156, Ends at:285)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | * | WARNING | 15 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 60 | | OK | 60 |
LOC: | 130 | | OK | 130 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_copy_map_lines(Begins at: 44, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | ** | BABY-MONSTER | 10 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 20 | *** | MONSTER | 20 |
LOC: | 56 | ** | BABY-MONSTER | 56 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_copy_table(Begins at: 644, Ends at:650)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | * | WARNING | 1 |
ParamNBR: | 6 | | OK | 6 |
CalledNBR: | 1 | * | WARNING | 1 |
LOC: | 7 | * | WARNING | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Vect_copy_table_by_cats(Begins at: 667, Ends at:720)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 54 | | OK | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_copy_tables(Begins at: 567, Ends at:629)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 63 | * | WARNING | 63 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Vect_delete(Begins at: 430, Ends at:553)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | * | WARNING | 16 |
ParamNBR: | 1 | ** | BABY-MONSTER | 1 |
CalledNBR: | 62 | * | WARNING | 62 |
LOC: | 124 | * | WARNING | 124 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_rename(Begins at: 302, Ends at:420)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 50 | *** | MONSTER | 50 |
LOC: | 119 | ** | BABY-MONSTER | 119 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_set_category_index_update(Begins at: 746, Ends at:749)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | ** | BABY-MONSTER | 1 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 4 | ** | BABY-MONSTER | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_set_release_support(Begins at: 731, Ends at:734)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
copy_file(Begins at: 110, Ends at:141)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 32 | | OK | 32 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Sat Mar 21 04:24:52 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list