[GRASS-QA] GRASS QA: mmetz |plus.c plus_struct.c spindex.c spindex_rw.c | 32 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Sun Sep 13 07:12:33 EDT 2009


Hello mmetz,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/lib/vector/diglib/plus.c
*****************************************************************

          Function
dig_free_plus(Begins at: 241, Ends at:250)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_free_plus_areas(Begins at: 173, Ends at:200)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      28 |       |           OK |        28 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_free_plus_isles(Begins at: 207, Ends at:232)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      26 |       |           OK |        26 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_free_plus_lines(Begins at: 137, Ends at:166)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      30 |       |           OK |        30 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_free_plus_nodes(Begins at: 105, Ends at:130)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      26 |       |           OK |        26 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_init_plus(Begins at: 31, Ends at:98)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      68 |     * |      WARNING |        68 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_load_plus(Begins at: 262, Ends at:327)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      15 |    ** | BABY-MONSTER |        15 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      32 |    ** | BABY-MONSTER |        32 |
LOC:          |      66 |     * |      WARNING |        66 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_write_areas(Begins at: 437, Ends at:451)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      15 |       |           OK |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_write_isles(Begins at: 462, Ends at:476)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      15 |       |           OK |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_write_lines(Begins at: 412, Ends at:426)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      15 |       |           OK |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_write_nodes(Begins at: 388, Ends at:401)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      14 |       |           OK |        14 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_write_plus_file(Begins at: 338, Ends at:377)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      22 |     * |      WARNING |        22 |
LOC:          |      40 |       |           OK |        40 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file has 12 potentially cloned functions:
  dig_write_lines  dig_write_isles  dig_write_nodes  dig_write_lines  dig_write_areas  dig_write_nodes  dig_write_areas  dig_write_isles  dig_write_lines  dig_write_areas  dig_write_isles

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_areas are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_nodes
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_lines
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_isles

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_isles are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_nodes
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_lines
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_areas

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_lines are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_nodes
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_areas
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_isles

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_nodes are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_lines
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_areas
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c  dig_write_isles

*****************************************************************
          File :grass/trunk/lib/vector/diglib/plus_struct.c
*****************************************************************

          Function
dig_Rd_P_area(Begins at: 335, Ends at:402)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      18 |   *** |      MONSTER |        18 |
ParamNBR:     |       3 |       |           OK |         3 |
CalledNBR:    |      15 |   *** |      MONSTER |        15 |
LOC:          |      68 |    ** | BABY-MONSTER |        68 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Rd_P_isle(Begins at: 458, Ends at:514)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      57 |     * |      WARNING |        57 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Rd_P_line(Begins at: 148, Ends at:248)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      27 |    ** | BABY-MONSTER |        27 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      21 |     * |      WARNING |        21 |
LOC:          |     101 |     * |      WARNING |       101 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Rd_P_node(Begins at: 49, Ends at:101)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |   *** |      MONSTER |        13 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |      53 |    ** | BABY-MONSTER |        53 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Rd_Plus_head(Begins at: 566, Ends at:693)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      33 |    ** | BABY-MONSTER |        33 |
ParamNBR:     |       2 |     * |      WARNING |         2 |
CalledNBR:    |      41 |     * |      WARNING |        41 |
LOC:          |     128 |     * |      WARNING |       128 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Wr_P_area(Begins at: 404, Ends at:456)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |   *** |      MONSTER |        17 |
ParamNBR:     |       3 |       |           OK |         3 |
CalledNBR:    |      12 |    ** | BABY-MONSTER |        12 |
LOC:          |      53 |    ** | BABY-MONSTER |        53 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Wr_P_isle(Begins at: 516, Ends at:560)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      10 |     * |      WARNING |        10 |
LOC:          |      45 |     * |      WARNING |        45 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Wr_P_line(Begins at: 250, Ends at:333)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      27 |    ** | BABY-MONSTER |        27 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      21 |     * |      WARNING |        21 |
LOC:          |      84 |     * |      WARNING |        84 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Wr_P_node(Begins at: 103, Ends at:146)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |   *** |      MONSTER |        13 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      10 |     * |      WARNING |        10 |
LOC:          |      44 |     * |      WARNING |        44 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Wr_Plus_head(Begins at: 695, Ends at:788)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      31 |    ** | BABY-MONSTER |        31 |
ParamNBR:     |       2 |     * |      WARNING |         2 |
CalledNBR:    |      34 |     * |      WARNING |        34 |
LOC:          |      94 |     * |      WARNING |        94 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/lib/vector/diglib/spindex.c
*****************************************************************

          Function
_add_item(Begins at: 368, Ends at:372)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


_add_node(Begins at: 405, Ends at:409)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_find_node(Begins at: 420, Ends at:441)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      22 |       |           OK |        22 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_select_areas(Begins at: 481, Ends at:499)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_select_isles(Begins at: 510, Ends at:528)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_select_lines(Begins at: 452, Ends at:470)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_select_nodes(Begins at: 384, Ends at:402)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_spidx_add_area(Begins at: 174, Ends at:189)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      16 |       |           OK |        16 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_spidx_add_isle(Begins at: 201, Ends at:216)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      16 |       |           OK |        16 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_spidx_add_line(Begins at: 148, Ends at:163)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      16 |       |           OK |        16 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_spidx_add_node(Begins at: 119, Ends at:137)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_spidx_del_area(Begins at: 303, Ends at:330)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      28 |       |           OK |        28 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_del_isle(Begins at: 342, Ends at:365)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      24 |       |           OK |        24 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_del_line(Begins at: 263, Ends at:291)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      29 |       |           OK |        29 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_del_node(Begins at: 228, Ends at:251)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      24 |       |           OK |        24 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_free(Begins at: 101, Ends at:107)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |       7 |       |           OK |         7 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_free_areas(Begins at: 79, Ends at:83)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_free_isles(Begins at: 90, Ends at:94)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_free_lines(Begins at: 68, Ends at:72)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_free_nodes(Begins at: 57, Ends at:61)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_spidx_init(Begins at: 31, Ends at:50)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      20 |       |           OK |        20 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 20 potentially cloned functions:
  dig_select_lines  dig_select_isles  dig_select_nodes  dig_select_lines  dig_select_areas  dig_select_nodes  dig_select_areas  dig_select_isles  dig_select_lines  dig_select_areas  dig_select_isles  dig_spidx_add_line  dig_spidx_add_isle  dig_spidx_add_line  dig_spidx_add_area  dig_spidx_add_area  dig_spidx_add_isle  dig_spidx_del_node  dig_spidx_del_isle

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_areas are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_nodes
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_lines
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_isles

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_isles are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_nodes
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_lines
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_areas

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_lines are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_nodes
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_areas
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_isles

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_nodes are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_lines
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_areas
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_select_isles

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_add_area are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_add_line
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_add_isle

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_add_isle are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_add_line
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_add_area

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_add_line are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_add_area
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_add_isle

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_del_isle are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_del_node

In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_del_node are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c  dig_spidx_del_isle

*****************************************************************
          File :grass/trunk/lib/vector/diglib/spindex_rw.c
*****************************************************************

          Function
dig_Rd_spindx_head(Begins at: 79, Ends at:162)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      22 |     * |      WARNING |        22 |
LOC:          |      84 |     * |      WARNING |        84 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dig_Wr_spindx_head(Begins at: 23, Ends at:76)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      16 |     * |      WARNING |        16 |
LOC:          |      54 |     * |      WARNING |        54 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


dig_dump_spidx(Begins at: 383, Ends at:399)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      17 |       |           OK |        17 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


dig_read_spidx(Begins at: 356, Ends at:380)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      25 |       |           OK |        25 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


dig_write_spidx(Begins at: 330, Ends at:353)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      24 |       |           OK |        24 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


rtree_dump_branch(Begins at: 167, Ends at:183)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      17 |       |           OK |        17 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


rtree_dump_node(Begins at: 186, Ends at:205)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      20 |       |           OK |        20 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


rtree_read_branch(Begins at: 268, Ends at:302)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      35 |       |           OK |        35 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


rtree_read_node(Begins at: 305, Ends at:327)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      23 |       |           OK |        23 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


rtree_write_branch(Begins at: 210, Ends at:237)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      28 |       |           OK |        28 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


rtree_write_node(Begins at: 240, Ends at:263)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      24 |       |           OK |        24 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Sun Sep 13 07:12:32 EDT 2009 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list