[GRASS-QA] GRASS QA: aghisla |Iwave.cpp GeomCond.cpp GeomCond.h Iwave.h | no clones | 1 monsters |5 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Tue Aug 10 12:03:01 EDT 2010


Hello aghisla,

here's a report on your recent grass-SVN change for the revision : 42884 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/imagery/i.atcorr/Iwave.cpp
*****************************************************************

          Class
IWave(Begins at: -9999, Ends at:-9999)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |    253 |     54 |      0 |    190 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |    243 |     52 |      0 |    171 |
+------------+--------+--------+--------+--------+--------+--------+

          Method
parse(Begins at: 2204, Ends at:2265)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      23 |    ** | BABY-MONSTER |        22 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      28 |     * |      WARNING |        27 |
LOC:          |      62 |       |           OK |        61 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!

print(Begins at: 2268, Ends at:2376)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |     137 |   *** |      MONSTER |       134 |
LOC:          |     109 |     * |      WARNING |       108 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!

avnir(Begins at: 1963, Ends at:2041)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      79 |     * |      WARNING |        79 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!

ikonos(Begins at: 2045, Ends at:2183)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |           |
ParamNBR:     |       1 |       |           OK |           |
CalledNBR:    |       0 |       |           OK |           |
LOC:          |     139 |     * |      WARNING |           |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!

equivwl(Begins at: 2185, Ends at:2202)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      18 |       |           OK |        18 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.atcorr/GeomCond.cpp
*****************************************************************

          Class
GeomCond(Begins at: -9999, Ends at:-9999)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |     51 |     89 |      0 |     45 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |     50 |     89 |      0 |     45 |
+------------+--------+--------+--------+--------+--------+--------+

          Method
parse(Begins at: 314, Ends at:409)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      20 |     * |      WARNING |        19 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      23 |     * |      WARNING |        23 |
LOC:          |      96 |     * |      WARNING |        95 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!

print(Begins at: 412, Ends at:482)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      61 |    ** | BABY-MONSTER |        60 |
LOC:          |      71 |     * |      WARNING |        70 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.atcorr/GeomCond.h
*****************************************************************

          Class
GeomCond(Begins at: 66, Ends at:107)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |     10 |      0 |     45 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |     10 |      0 |     45 |
+------------+--------+--------+--------+--------+--------+--------+



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.atcorr/Iwave.h
*****************************************************************

          Class
FFu(Begins at: 125, Ends at:130)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------+



          Class
IWave(Begins at: 115, Ends at:165)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |     20 |      0 |    190 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |     19 |      0 |    171 |
+------------+--------+--------+--------+--------+--------+--------+



Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Aug 10 12:02:57 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        42 |        66 |
LOC:                  |        65 |       147 |       230 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list