[GRASS-QA] GRASS QA: mmetz |remove_areas.c write_nat.c build_nat.c | no clones | 3 monsters |2 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Tue Aug 10 15:18:41 EDT 2010


Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 42962 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/vector/Vlib/remove_areas.c
*****************************************************************

          Function
Vect_remove_small_areas(Begins at: 35, Ends at:185)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |    ** | BABY-MONSTER |        21 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      45 |    ** | BABY-MONSTER |        45 |
LOC:          |     151 |    ** | BABY-MONSTER |       151 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Vect_remove_small_areas_faster(Begins at: 188, Ends at:316)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |     * |      WARNING |        17 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      38 |     * |      WARNING |        38 |
LOC:          |     129 |     * |      WARNING |       129 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


Vect_remove_small_areas_fastest(Begins at: 319, Ends at:660)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      64 |   *** |      MONSTER |        64 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |     117 |   *** |      MONSTER |       117 |
LOC:          |     342 |   *** |      MONSTER |       342 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/Vlib/write_nat.c
*****************************************************************

          Function
V2__add_line_to_topo_nat(Begins at: 136, Ends at:305)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      34 |   *** |      MONSTER |        34 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      33 |     * |      WARNING |        33 |
LOC:          |     170 |    ** | BABY-MONSTER |       170 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


V2_delete_line_nat(Begins at: 655, Ends at:841)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      34 |   *** |      MONSTER |        34 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      42 |    ** | BABY-MONSTER |        42 |
LOC:          |     187 |    ** | BABY-MONSTER |       187 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/Vlib/build_nat.c
*****************************************************************

          Function
Vect_attach_isles(Begins at: 306, Ends at:332)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Aug 10 15:18:36 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        65 |       147 |       230 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list