[GRASS-QA] GRASS QA: mmetz |open.c | 2 clones | 1 monsters |1 warnings

[soccerlab.info at gmail.com]

Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 43072 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/vector/Vlib/open.c
*****************************************************************

          Function
Vect__open_old(Begins at: 131, Ends at:474)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      44 |   *** |      MONSTER |        44 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |     130 |   *** |      MONSTER |       130 |
LOC:          |     344 |   *** |      MONSTER |       344 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Vect_open_topo(Begins at: 874, Ends at:945)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      15 |       |           OK |        15 |
LOC:          |      72 |     * |      WARNING |        72 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 2 potentially cloned functions:
  Vect_open_topo

In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect__open_old are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c  Vect__open_old

In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect_open_topo are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c  Vect_open_topo

____________________________________________


Threshold grass key metrics values at Thu Aug 12 13:30:31 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        43 |        69 |
LOC:                  |        66 |       148 |       231 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html