[GRASS-QA] GRASS QA: mmetz |ami_stream.h | no clones | 0 monsters
|2 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Sat Aug 14 12:24:41 EDT 2010
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 43099
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/include/iostream/ami_stream.h
*****************************************************************
Class
AMI_STREAM(Begins at: 153, Ends at:204)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 2 | 0 | 0 | 14 | 1 | 91 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 2 | 0 | 0 | 14 | 1 | 91 |
+------------+--------+--------+--------+--------+--------+--------+
Class
AMI_STREAM<T>(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 38 | 66 | 0 | 66 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 34 | 38 | 0 | 6 |
+------------+--------+--------+--------+--------+--------+--------+
Method
write_array(Begins at: 624, Ends at:641)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 7 | | OK | |
LOC: | 18 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
read_array(Begins at: 569, Ends at:595)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | |
ParamNBR: | 3 | * | WARNING | |
CalledNBR: | 7 | | OK | |
LOC: | 27 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
seek(Begins at: 455, Ends at:480)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 24 |
ParamNBR: | 1 | | OK | 21 |
CalledNBR: | 5 | | OK | 49 |
LOC: | 26 | | OK | 228 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
write_item(Begins at: 602, Ends at:619)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 8 | | OK | |
LOC: | 18 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
read_item(Begins at: 539, Ends at:562)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 7 | | OK | |
LOC: | 24 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
stream_len(Begins at: 382, Ends at:428)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 47 | | OK | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Class
UntypedStream(Begins at: 122, Ends at:150)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 1 | 1 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 1 | 1 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Sat Aug 14 12:24:38 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 65 | 147 | 230 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list