[GRASS-QA] GRASS QA: avitti |varseg.h main.c varseg.c | no clones | 7 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Fri Aug 27 10:30:40 EDT 2010


Hello avitti,

here's a report on your recent grass-SVN change for the revision : 43303 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/raster/r.seg/include/varseg/varseg.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/raster/r.seg/rseg/main.c
*****************************************************************

          Function
main(Begins at: 30, Ends at:326)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      22 |    ** | BABY-MONSTER |        22 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     105 |   *** |      MONSTER |       105 |
LOC:          |     297 |   *** |      MONSTER |       297 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/raster/r.seg/varseglib/varseg.c
*****************************************************************

          Function
ms_n(Begins at: 74, Ends at:173)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |     100 |     * |      WARNING |       100 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


ms_o(Begins at: 431, Ends at:544)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |     114 |     * |      WARNING |       114 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


ms_t(Begins at: 806, Ends at:899)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      94 |     * |      WARNING |        94 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


msk_n(Begins at: 222, Ends at:387)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |      10 |   *** |      MONSTER |        10 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |     166 |    ** | BABY-MONSTER |       166 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


msk_o(Begins at: 593, Ends at:760)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |      10 |   *** |      MONSTER |        10 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |     168 |    ** | BABY-MONSTER |       168 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


msk_t(Begins at: 950, Ends at:1120)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |      10 |   *** |      MONSTER |        10 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |     171 |    ** | BABY-MONSTER |       171 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Fri Aug 27 10:30:35 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        43 |        69 |
LOC:                  |        66 |       148 |       231 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list