[GRASS-QA] GRASS QA: mmetz |geom.c | no clones | 1 monsters |2 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Fri Aug 27 14:14:58 EDT 2010

```Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 43312

ANALYSIS

*****************************************************************
File :/vector/v.in.ogr/geom.c
*****************************************************************

Function
geom(Begins at: 202, Ends at:429)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      35 |   *** |      MONSTER |        35 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      83 |   *** |      MONSTER |        83 |
LOC:          |     228 |    ** | BABY-MONSTER |       228 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

centroid(Begins at: 32, Ends at:170)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |    ** | BABY-MONSTER |        19 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      44 |    ** | BABY-MONSTER |        44 |
LOC:          |     139 |     * |      WARNING |       139 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

split_line(Begins at: 431, Ends at:478)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      13 |       |           OK |        13 |
LOC:          |      48 |       |           OK |        48 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

poly_count(Begins at: 173, Ends at:199)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      10 |       |           OK |        10 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

Clone analysis:
This file does not contain cloned functions

____________________________________________

Threshold grass key metrics values at Fri Aug 27 14:14:55 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning   | middle    | extrem    |
| limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        43 |        69 |
LOC:                  |        66 |       148 |       231 |
----------------------+-----------+-----------+-----------+

Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
OK : Nothing to say at all
*  : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function

Conclusion interpretation :
CORRECT     : if all metrics are situated before warning limits
WARNING     : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS    : if 1 to more metrics are in the extreme limits

_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory