[GRASS-QA] GRASS QA: mmetz |main.c | 1 clones | 1 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Sat Jul 10 16:28:39 EDT 2010
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 42648
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/raster/r.resamp.bspline/main.c
*****************************************************************
Function
main(Begins at: 27, Ends at:639)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 48 | *** | MONSTER | 48 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 216 | *** | MONSTER | 216 |
LOC: | 613 | *** | MONSTER | 613 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/main.c main
____________________________________________
Threshold grass key metrics values at Sat Jul 10 16:28:26 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 10 | 22 | 34 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 19 | 44 | 70 |
LOC: | 72 | 163 | 255 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list