[GRASS-QA] GRASS QA: hamish |random.c main.c | no clones | 1 monsters |1 warnings

[soccerlab.info at gmail.com]

Hello hamish,

here's a report on your recent grass-SVN change for the revision : 42422 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/raster/r.random/random.c
*****************************************************************

          Function
execute_random(Begins at: 17, Ends at:257)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      46 |   *** |      MONSTER |        46 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      91 |   *** |      MONSTER |        91 |
LOC:          |     241 |    ** | BABY-MONSTER |       241 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/raster/r.random/main.c
*****************************************************************

          Function
main(Begins at: 30, Ends at:178)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      44 |     * |      WARNING |        44 |
LOC:          |     149 |     * |      WARNING |       149 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Jun 01 15:27:25 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |        11 |        26 |        41 |
ParamNBR:             |         4 |         8 |        13 |
CalledNBR:            |        21 |        49 |        78 |
LOC:                  |        79 |       181 |       283 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html