[GRASS-QA] GRASS QA: |main.c correction.h outlier.h main.c ...| 73
clones | 11 monsters |23 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Thu May 20 16:11:49 EDT 2010
Hello ,
here's a report on your recent grass-SVN change for the revision : 42319
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/vector/v.outlier/main.c
*****************************************************************
Function
main(Begins at: 32, Ends at:446)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 36 | ** | BABY-MONSTER | 36 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 161 | *** | MONSTER | 161 |
LOC: | 415 | *** | MONSTER | 415 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/main.c main
*****************************************************************
File :/vector/v.lidar.correction/correction.h
*****************************************************************
Class
lidar_cat(Begins at: 10, Ends at:16)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | | | | | | |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/vector/v.outlier/outlier.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/vector/v.lidar.growing/main.c
*****************************************************************
Function
main(Begins at: 34, Ends at:572)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 54 | *** | MONSTER | 54 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 141 | *** | MONSTER | 141 |
LOC: | 539 | *** | MONSTER | 539 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/main.c main
*****************************************************************
File :/vector/v.lidar.correction/correction.c
*****************************************************************
Function
Insert_Correction(Begins at: 279, Ends at:294)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
P_Read_Vector_Correction(Begins at: 312, Ends at:392)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 20 | | OK | 20 |
LOC: | 81 | * | WARNING | 81 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
P_Sparse_Correction(Begins at: 27, Ends at:223)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 29 | ** | BABY-MONSTER | 29 |
ParamNBR: | 21 | *** | MONSTER | 21 |
CalledNBR: | 70 | ** | BABY-MONSTER | 70 |
LOC: | 197 | ** | BABY-MONSTER | 197 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Select_Correction(Begins at: 244, Ends at:277)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 34 | | OK | 34 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
UpDate_Correction(Begins at: 296, Ends at:310)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
correction(Begins at: 226, Ends at:242)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 14 potentially cloned functions:
Insert_Interpolation Insert_Outlier Insert_Interpolation Insert_Outlier P_Read_Vector_Correction P_Sparse_Correction Select_Correction Select_Outlier Select_Outlier UpDate_Correction UpDate_Outlier UpDate_Outlier correction
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c clones of Insert_Correction are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c Insert_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c Insert_Interpolation
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c Insert_Outlier
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c Insert_Interpolation
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c Insert_Outlier
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c clones of P_Read_Vector_Correction are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c P_Read_Vector_Correction
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c clones of P_Sparse_Correction are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c P_Sparse_Correction
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c clones of Select_Correction are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c Select_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c Select_Outlier
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c Select_Outlier
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c clones of UpDate_Correction are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c UpDate_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c UpDate_Outlier
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c UpDate_Outlier
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c clones of correction are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c correction
*****************************************************************
File :/vector/v.lidar.edgedetection/edgedetection.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/vector/v.lidar.edgedetection/edgedetection.c
*****************************************************************
Function
Get_Gradient(Begins at: 136, Ends at:157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 22 | | OK | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Insert(Begins at: 394, Ends at:413)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Insert_Interpolation(Begins at: 415, Ends at:432)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Select(Begins at: 454, Ends at:507)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 23 | * | WARNING | 23 |
LOC: | 54 | | OK | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
UpDate(Begins at: 435, Ends at:452)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
classification(Begins at: 159, Ends at:392)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 25 | ** | BABY-MONSTER | 25 |
ParamNBR: | 17 | *** | MONSTER | 17 |
CalledNBR: | 65 | ** | BABY-MONSTER | 65 |
LOC: | 234 | ** | BABY-MONSTER | 234 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
edge_detection(Begins at: 32, Ends at:134)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 103 | * | WARNING | 103 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 11 potentially cloned functions:
Insert Insert_Correction Insert_Interpolation Insert_Outlier Insert_Correction Insert_Outlier Select UpDate classification edge_detection
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c clones of Get_Gradient are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c Get_Gradient
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c clones of Insert are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c Insert
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c clones of Insert_Interpolation are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c Insert_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c Insert_Interpolation
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c Insert_Outlier
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c Insert_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c Insert_Outlier
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c clones of Select are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c Select
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c clones of UpDate are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c UpDate
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c clones of classification are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c classification
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c clones of edge_detection are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c edge_detection
*****************************************************************
File :/vector/v.outlier/outlier.c
*****************************************************************
Function
Insert_Outlier(Begins at: 209, Ends at:226)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
P_Outlier(Begins at: 9, Ends at:207)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 33 | ** | BABY-MONSTER | 33 |
ParamNBR: | 14 | *** | MONSTER | 14 |
CalledNBR: | 65 | ** | BABY-MONSTER | 65 |
LOC: | 199 | ** | BABY-MONSTER | 199 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
P_is_outlier(Begins at: 282, Ends at:288)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Select_Outlier(Begins at: 246, Ends at:280)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 35 | | OK | 35 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
UpDate_Outlier(Begins at: 228, Ends at:244)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 12 potentially cloned functions:
Insert_Interpolation Insert_Outlier Insert_Correction Insert_Interpolation P_Outlier Select_Correction Select_Outlier Select_Correction UpDate_Correction UpDate_Outlier UpDate_Correction
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c clones of Insert_Outlier are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c Insert_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c Insert_Interpolation
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c Insert_Outlier
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c Insert_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/edgedetection.c Insert_Interpolation
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c clones of P_Outlier are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c P_Outlier
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c clones of Select_Outlier are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c Select_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c Select_Outlier
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c Select_Correction
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.outlier/outlier.c clones of UpDate_Outlier are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/correction.c UpDate_Correction
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.outlier/outlier.c UpDate_Outlier
/data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/correction.c UpDate_Correction
*****************************************************************
File :/vector/v.surf.bspline/bspline.h
*****************************************************************
Class
Param(Begins at: 36, Ends at:41)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | | | | | | |
+------------+--------+--------+--------+--------+--------+--------+
Class
Stats(Begins at: 29, Ends at:34)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | | | | | | |
+------------+--------+--------+--------+--------+--------+--------+
Class
SubZone(Begins at: 43, Ends at:47)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | | | | | | |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/vector/v.lidar.growing/ConvexHull.c
*****************************************************************
Function
P_alloc_element(Begins at: 247, Ends at:262)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Pvector(Begins at: 236, Ends at:245)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
ccw(Begins at: 79, Ends at:90)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
ch2d(Begins at: 125, Ends at:134)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
checkHull(Begins at: 147, Ends at:187)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
cmph(Begins at: 102, Ends at:105)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
cmpl(Begins at: 93, Ends at:100)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
free_Pvector(Begins at: 304, Ends at:308)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
free_structmatrix(Begins at: 310, Ends at:315)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
make_chain(Begins at: 107, Ends at:123)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
nrerror(Begins at: 264, Ends at:271)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
pianOriz(Begins at: 190, Ends at:233)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 44 | | OK | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
print_hull(Begins at: 136, Ends at:145)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
regGrow8(Begins at: 11, Ends at:77)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | * | WARNING | 17 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 67 | | OK | 67 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
structMatrix(Begins at: 273, Ends at:302)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 10 potentially cloned functions:
Pvector ccw ch2d checkHull make_chain pianOriz print_hull regGrow8 structMatrix
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of P_alloc_element are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c P_alloc_element
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of Pvector are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c Pvector
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of ccw are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c ccw
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of ch2d are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c ch2d
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of checkHull are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c checkHull
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of make_chain are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c make_chain
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of pianOriz are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c pianOriz
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of print_hull are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c print_hull
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of regGrow8 are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c regGrow8
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/ConvexHull.c clones of structMatrix are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/ConvexHull.c structMatrix
*****************************************************************
File :/vector/v.surf.bspline/crosscorr.c
*****************************************************************
Function
alloc_Stats(Begins at: 399, Ends at:412)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
calc_mean(Begins at: 356, Ends at:366)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
calc_root_mean_square(Begins at: 369, Ends at:383)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
calc_standard_deviation(Begins at: 385, Ends at:397)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
cross_correlation(Begins at: 33, Ends at:327)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | * | WARNING | 21 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 89 | *** | MONSTER | 89 |
LOC: | 295 | *** | MONSTER | 295 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
find_minimum(Begins at: 414, Ends at:428)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
interpolation(Begins at: 330, Ends at:353)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
swap(Begins at: 430, Ends at:439)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 20 potentially cloned functions:
alloc_Stats alloc_Stats calc_mean calc_mean calc_mean calc_root_mean_square calc_root_mean_square calc_root_mean_square calc_standard_deviation calc_standard_deviation calc_standard_deviation cross_correlation find_minimum find_minimum find_minimum interpolation interpolation interpolation swap
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of alloc_Stats are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/crosscorr.c alloc_Stats
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/crosscorr.c alloc_Stats
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c alloc_Stats
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of calc_mean are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/crosscorr.c calc_mean
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/crosscorr.c calc_mean
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c calc_mean
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of calc_root_mean_square are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/crosscorr.c calc_root_mean_square
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/crosscorr.c calc_root_mean_square
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c calc_root_mean_square
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of calc_standard_deviation are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/crosscorr.c calc_standard_deviation
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/crosscorr.c calc_standard_deviation
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c calc_standard_deviation
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of cross_correlation are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c cross_correlation
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of find_minimum are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/crosscorr.c find_minimum
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/crosscorr.c find_minimum
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c find_minimum
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of interpolation are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/crosscorr.c interpolation
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/crosscorr.c interpolation
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c interpolation
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/crosscorr.c clones of swap are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/crosscorr.c swap
*****************************************************************
File :/vector/v.lidar.growing/growing.h
*****************************************************************
Class
element_grow(Begins at: 20, Ends at:31)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | | | | | | |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/vector/v.lidar.growing/growing.c
*****************************************************************
Function
P_Aux_to_Coor(Begins at: 6, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 20 | | OK | 20 |
LOC: | 60 | | OK | 60 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.growing/growing.c clones of P_Aux_to_Coor are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.growing/growing.c P_Aux_to_Coor
*****************************************************************
File :/vector/v.lidar.edgedetection/main.c
*****************************************************************
Function
main(Begins at: 37, Ends at:482)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 35 | ** | BABY-MONSTER | 35 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 186 | *** | MONSTER | 186 |
LOC: | 446 | *** | MONSTER | 446 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.edgedetection/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.edgedetection/main.c main
*****************************************************************
File :/vector/v.lidar.correction/main.c
*****************************************************************
Function
main(Begins at: 29, Ends at:449)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 32 | ** | BABY-MONSTER | 32 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 172 | *** | MONSTER | 172 |
LOC: | 421 | *** | MONSTER | 421 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.lidar.correction/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.lidar.correction/main.c main
*****************************************************************
File :/vector/v.surf.bspline/main.c
*****************************************************************
Function
main(Begins at: 33, Ends at:759)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 71 | *** | MONSTER | 71 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 252 | *** | MONSTER | 252 |
LOC: | 727 | *** | MONSTER | 727 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/v.surf.bspline/main.c main
____________________________________________
Threshold grass key metrics values at Thu May 20 16:11:39 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 11 | 24 | 38 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 21 | 49 | 78 |
LOC: | 78 | 179 | 281 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list