[GRASS-QA] GRASS QA: mmetz |parse.c main.c local_proto.h | no clones | 1 monsters |1 warnings

[soccerlab.info at gmail.com]

Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 42313 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/vector/v.info/parse.c
*****************************************************************

          Function
parse_args(Begins at: 6, Ends at:54)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |      21 |       |           OK |        21 |
LOC:          |      49 |       |           OK |        49 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/vector/v.info/main.c
*****************************************************************

          Function
main(Begins at: 25, Ends at:92)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      28 |     * |      WARNING |        28 |
LOC:          |      68 |       |           OK |        68 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/vector/v.info/local_proto.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
____________________________________________


Threshold grass key metrics values at Thu May 20 15:50:04 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |        11 |        24 |        38 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        23 |        54 |        86 |
LOC:                  |        80 |       183 |       287 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html