[GRASS-QA] GRASS QA: mmetz |open_nat.c open.c | 3 clones | 0
monsters |1 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Thu May 20 16:19:05 EDT 2010
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 42321
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/vector/Vlib/open_nat.c
*****************************************************************
Function
V1_open_old_nat(Begins at: 40, Ends at:81)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 42 | | OK | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
V1_open_new_nat(Begins at: 93, Ends at:140)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 17 | | OK | 17 |
LOC: | 48 | | OK | 48 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
check_coor(Begins at: 143, Ends at:163)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/open.c
*****************************************************************
Function
Vect_open_sidx(Begins at: 958, Ends at:1047)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 17 | | OK | 17 |
LOC: | 90 | * | WARNING | 90 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Vect_coor_info(Begins at: 772, Ends at:812)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | | OK | 10 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_open_topo(Begins at: 875, Ends at:947)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 15 | | OK | 15 |
LOC: | 73 | | OK | 73 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
Vect_coor_info Vect_open_topo
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect_open_sidx are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_sidx
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect_coor_info are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_coor_info
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect_open_topo are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_topo
____________________________________________
Threshold grass key metrics values at Thu May 20 16:18:54 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 11 | 26 | 41 |
ParamNBR: | 4 | 8 | 13 |
CalledNBR: | 21 | 49 | 78 |
LOC: | 78 | 178 | 279 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list