[GRASS-QA] GRASS QA: hamish |main.c | 2 clones | 1 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello hamish,

here's a report on your recent grass-SVN change for the revision : 42410 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/raster/r.out.png/main.c
*****************************************************************

          Function
write_wld(Begins at: 420, Ends at:443)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      16 |       |           OK |        16 |
LOC:          |      24 |       |           OK |        24 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


main(Begins at: 50, Ends at:386)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      29 |    ** | BABY-MONSTER |        29 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      97 |   *** |      MONSTER |        97 |
LOC:          |     337 |   *** |      MONSTER |       337 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 2 potentially cloned functions:
  write_tfw

In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.out.png/main.c clones of write_wld are:
          /data/project-manager/grass/grassSVN/grass/trunk/raster/r.out.tiff/main.c  write_tfw
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.out.tiff/main.c  write_tfw

____________________________________________


Threshold grass key metrics values at Mon May 31 22:54:57 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |        11 |        26 |        41 |
ParamNBR:             |         4 |         8 |        13 |
CalledNBR:            |        21 |        49 |        78 |
LOC:                  |        78 |       179 |       281 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html