[GRASS-QA] GRASS QA: neteler |main.c gshhs.h | no clones | 3 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello neteler,

here's a report on your recent grass-SVN change for the revision : 43701 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/vector/v.in.gshhs/main.c
*****************************************************************

          Function
gshhs_import1(Begins at: 372, Ends at:689)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      59 |   *** |      MONSTER |        59 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      68 |   *** |      MONSTER |        68 |
LOC:          |     318 |   *** |      MONSTER |       318 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


main(Begins at: 53, Ends at:369)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      28 |    ** | BABY-MONSTER |        28 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     104 |   *** |      MONSTER |       104 |
LOC:          |     317 |   *** |      MONSTER |       317 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


gshhs_import2(Begins at: 695, Ends at:1012)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      59 |   *** |      MONSTER |        59 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      68 |   *** |      MONSTER |        68 |
LOC:          |     318 |   *** |      MONSTER |       318 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/vector/v.in.gshhs/gshhs.h
*****************************************************************

          Class
GSHHS(Begins at: 69, Ends at:85)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



          Class
GSHHS_POINT(Begins at: 87, Ends at:90)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Nov 02 18:03:13 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        66 |       150 |       234 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html