[GRASS-QA] GRASS QA: martinl |main.c tools.c main.c local_proto.h
...| 4 clones | 2 monsters |5 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Nov 3 08:25:24 EDT 2010
Hello martinl,
here's a report on your recent grass-SVN change for the revision : 44039
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/imagery/i.landsat.toar/main.c
*****************************************************************
Function
main(Begins at: 29, Ends at:632)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 66 | *** | MONSTER | 66 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 219 | *** | MONSTER | 219 |
LOC: | 604 | *** | MONSTER | 604 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.landsat.acca/tools.c
*****************************************************************
Function
filter_holes(Begins at: 109, Ends at:303)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 26 | ** | BABY-MONSTER | 26 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 79 | *** | MONSTER | 79 |
LOC: | 195 | ** | BABY-MONSTER | 195 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
hist_put(Begins at: 27, Ends at:40)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
moment(Begins at: 43, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
pval(Begins at: 99, Ends at:107)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
quantile(Begins at: 68, Ends at:91)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
moment quantile
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.landsat.acca/tools.c clones of hist_put are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/i.landsat.acca/tools.c hist_put
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.landsat.acca/tools.c clones of moment are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/i.landsat.acca/tools.c moment
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.landsat.acca/tools.c clones of quantile are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/i.landsat.acca/tools.c quantile
*****************************************************************
File :/imagery/i.landsat.acca/main.c
*****************************************************************
Function
check_raster(Begins at: 50, Ends at:73)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 80, Ends at:222)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 56 | ** | BABY-MONSTER | 56 |
LOC: | 143 | * | WARNING | 143 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.landsat.acca/local_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/imagery/i.landsat.acca/algorithm.c
*****************************************************************
Function
acca_algorithm(Begins at: 76, Ends at:211)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 50 | ** | BABY-MONSTER | 50 |
LOC: | 136 | * | WARNING | 136 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
acca_first(Begins at: 214, Ends at:358)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | ** | BABY-MONSTER | 21 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 145 | * | WARNING | 145 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
acca_second(Begins at: 361, Ends at:449)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 38 | * | WARNING | 38 |
LOC: | 89 | * | WARNING | 89 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
shadow_algorithm(Begins at: 457, Ends at:472)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.landsat.acca/algorithm.c clones of shadow_algorithm are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/i.landsat.acca/algorithm.c shadow_algorithm
____________________________________________
Threshold grass key metrics values at Wed Nov 03 08:25:19 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 18 | 43 | 69 |
LOC: | 67 | 151 | 235 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list