[GRASS-QA] GRASS QA: aghisla |Iwave.cpp GeomCond.cpp GeomCond.h
Iwave.h | no clones | 1 monsters |5 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Mon Nov 29 19:37:02 EST 2010
Hello aghisla,
here's a report on your recent grass-SVN change for the revision : 44358
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/imagery/i.atcorr/Iwave.cpp
*****************************************************************
Class
IWave(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 267 | 56 | 0 | 210 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 253 | 54 | 0 | 190 |
+------------+--------+--------+--------+--------+--------+--------+
Method
parse(Begins at: 2298, Ends at:2360)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 24 | ** | BABY-MONSTER | 23 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 29 | * | WARNING | 28 |
LOC: | 63 | | OK | 62 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
equivwl(Begins at: 2279, Ends at:2296)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
rapideye(Begins at: 2187, Ends at:2277)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | * | WARNING | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 0 | | OK | |
LOC: | 91 | * | WARNING | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
ikonos(Begins at: 2045, Ends at:2183)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 139 | * | WARNING | 139 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
print(Begins at: 2363, Ends at:2473)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 143 | *** | MONSTER | 137 |
LOC: | 111 | * | WARNING | 109 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.atcorr/GeomCond.cpp
*****************************************************************
Class
GeomCond(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 52 | 89 | 0 | 45 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 51 | 89 | 0 | 45 |
+------------+--------+--------+--------+--------+--------+--------+
Method
print(Begins at: 413, Ends at:484)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 62 | ** | BABY-MONSTER | 61 |
LOC: | 72 | * | WARNING | 71 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
parse(Begins at: 314, Ends at:410)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | ** | BABY-MONSTER | 20 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 23 | * | WARNING | 23 |
LOC: | 97 | * | WARNING | 96 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.atcorr/GeomCond.h
*****************************************************************
Class
GeomCond(Begins at: 68, Ends at:109)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 10 | 0 | 45 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 10 | 0 | 45 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.atcorr/Iwave.h
*****************************************************************
Class
FFu(Begins at: 130, Ends at:135)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
IWave(Begins at: 120, Ends at:171)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 21 | 0 | 210 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 20 | 0 | 190 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Mon Nov 29 19:36:45 EST 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 18 | 43 | 69 |
LOC: | 68 | 153 | 239 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list