[GRASS-QA] GRASS QA: martinl |main.c main.c main.c main.c ...| no
clones | 6 monsters |2 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Mon Nov 29 23:50:01 EST 2010
Hello martinl,
here's a report on your recent grass-SVN change for the revision : 44455
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/vector/v.in.dxf/main.c
*****************************************************************
Function
main(Begins at: 36, Ends at:182)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | * | WARNING | 13 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 62 | ** | BABY-MONSTER | 62 |
LOC: | 147 | * | WARNING | 147 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.colors/main.c
*****************************************************************
Function
main(Begins at: 139, Ends at:395)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 38 | *** | MONSTER | 38 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 113 | *** | MONSTER | 113 |
LOC: | 257 | *** | MONSTER | 257 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.out.gdal/main.c
*****************************************************************
Function
main(Begins at: 106, Ends at:613)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 68 | *** | MONSTER | 68 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 145 | *** | MONSTER | 145 |
LOC: | 508 | *** | MONSTER | 508 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/vector/v.in.ogr/main.c
*****************************************************************
Function
main(Begins at: 50, Ends at:1219)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 117 | *** | MONSTER | 117 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 454 | *** | MONSTER | 454 |
LOC: | 1170 | *** | MONSTER | 1170 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.in.gdal/main.c
*****************************************************************
Function
main(Begins at: 50, Ends at:619)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 61 | *** | MONSTER | 61 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 209 | *** | MONSTER | 209 |
LOC: | 570 | *** | MONSTER | 570 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.mapset/main.c
*****************************************************************
Function
main(Begins at: 28, Ends at:218)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | * | WARNING | 19 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 87 | *** | MONSTER | 87 |
LOC: | 191 | ** | BABY-MONSTER | 191 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.external/main.c
*****************************************************************
Class
band_info(Begins at: 36, Ends at:44)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
main(Begins at: 501, Ends at:693)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 22 | ** | BABY-MONSTER | 22 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 86 | *** | MONSTER | 86 |
LOC: | 193 | ** | BABY-MONSTER | 193 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.external.out/main.c
*****************************************************************
Function
main(Begins at: 201, Ends at:289)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 38 | * | WARNING | 38 |
LOC: | 89 | * | WARNING | 89 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Mon Nov 29 23:49:41 EST 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 10 | 22 | 34 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 18 | 43 | 69 |
LOC: | 68 | 153 | 239 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list