[GRASS-QA] GRASS QA: mmetz |resamp.c bspline.h main.c | 3 clones |
2 monsters |1 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Thu Sep 16 12:15:47 EDT 2010
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 43482
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/raster/r.resamp.bspline/resamp.c
*****************************************************************
Function
P_Read_Raster_Region_Nulls(Begins at: 25, Ends at:115)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | * | WARNING | 16 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 91 | * | WARNING | 91 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
P_Sparse_Raster_Points(Begins at: 117, Ends at:235)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | * | WARNING | 18 |
ParamNBR: | 15 | *** | MONSTER | 15 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 119 | * | WARNING | 119 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 2 potentially cloned functions:
P_Sparse_Raster_Points
In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/resamp.c clones of P_Read_Raster_Region_Nulls are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/resamp.c P_Read_Raster_Region_Nulls
In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/resamp.c clones of P_Sparse_Raster_Points are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/resamp.c P_Sparse_Raster_Points
*****************************************************************
File :/raster/r.resamp.bspline/bspline.h
*****************************************************************
Class
Param(Begins at: 29, Ends at:34)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
RasterPoint(Begins at: 36, Ends at:40)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Stats(Begins at: 22, Ends at:27)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.resamp.bspline/main.c
*****************************************************************
Function
main(Begins at: 27, Ends at:687)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 54 | *** | MONSTER | 54 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 235 | *** | MONSTER | 235 |
LOC: | 661 | *** | MONSTER | 661 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/main.c main
____________________________________________
Threshold grass key metrics values at Thu Sep 16 12:15:43 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 66 | 150 | 234 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list