[GRASS-QA] GRASS QA: hamish |points.c draw.c main.c local_proto.h | no clones | 3 monsters |1 warnings

[soccerlab.info at gmail.com]

Hello hamish,

here's a report on your recent grass-SVN change for the revision : 45827 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/display/d.barb/points.c
*****************************************************************

          Function
fill_arrays(Begins at: 141, Ends at:273)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |    ** | BABY-MONSTER |        21 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |      39 |    ** | BABY-MONSTER |        39 |
LOC:          |     133 |     * |      WARNING |       133 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


do_barb_points(Begins at: 10, Ends at:92)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |      28 |     * |      WARNING |        28 |
LOC:          |      83 |     * |      WARNING |        83 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/display/d.barb/draw.c
*****************************************************************

          Function
draw_barb(Begins at: 11, Ends at:45)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      35 |       |           OK |        35 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/display/d.barb/main.c
*****************************************************************

          Function
main(Begins at: 26, Ends at:261)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |     * |      WARNING |        19 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      89 |   *** |      MONSTER |        89 |
LOC:          |     236 |   *** |      MONSTER |       236 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/display/d.barb/local_proto.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
____________________________________________


Threshold grass key metrics values at Sun Apr 03 01:06:48 EDT 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        16 |        38 |        61 |
LOC:                  |        64 |       145 |       226 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html