[GRASS-QA] GRASS QA: mmetz |setup.c seek.c release.c format.c ...|
1 clones | 0 monsters |3 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Apr 8 02:41:44 EDT 2011
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 45869
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/segment/setup.c
*****************************************************************
Function
segment_setup(Begins at: 36, Ends at:153)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | * | WARNING | 19 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 118 | * | WARNING | 118 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/segment/seek.c
*****************************************************************
Function
segment_seek_slow(Begins at: 48, Ends at:58)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/lib/segment/seek.c clones of segment_seek_slow are:
/data/project-manager/grass/grassSVN/grass/trunk/lib/segment/seek.c segment_seek_fast
*****************************************************************
File :/lib/segment/release.c
*****************************************************************
Function
segment_release(Begins at: 36, Ends at:54)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/segment/format.c
*****************************************************************
Function
zero_fill(Begins at: 169, Ends at:213)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 45 | | OK | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/segment/get_row.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/segment/pagein.c
*****************************************************************
Function
segment_pagein(Begins at: 37, Ends at:121)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 85 | * | WARNING | 85 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/segment/pageout.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/segment/put_row.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/segment/put.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/segment/init.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
____________________________________________
Threshold grass key metrics values at Fri Apr 08 02:41:26 EDT 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 21 | 33 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 16 | 38 | 61 |
LOC: | 63 | 142 | 222 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list