[GRASS-QA] GRASS QA: martinl |build_ogr.c open_ogr.c | 1 clones | 0 monsters |3 warnings

[soccerlab.info at gmail.com]

Hello martinl,

here's a report on your recent grass-SVN change for the revision : 45910 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/vector/Vlib/build_ogr.c
*****************************************************************

          Function
Vect_build_ogr(Begins at: 338, Ends at:432)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      39 |    ** | BABY-MONSTER |        39 |
LOC:          |      95 |     * |      WARNING |        95 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/build_ogr.c clones of Vect_build_ogr are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/build_ogr.c  Vect_build_ogr

*****************************************************************
          File :/lib/vector/Vlib/open_ogr.c
*****************************************************************

          Function
V2_open_new_ogr(Begins at: 288, Ends at:348)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      16 |     * |      WARNING |        16 |
LOC:          |      61 |       |           OK |        61 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


V1_open_old_ogr(Begins at: 43, Ends at:122)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |     * |      WARNING |        17 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      22 |     * |      WARNING |        22 |
LOC:          |      80 |     * |      WARNING |        80 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Apr 12 02:30:32 EDT 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        16 |        38 |        61 |
LOC:                  |        63 |       142 |       222 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html