[GRASS-QA] GRASS QA: hamish |points.c grid.c main.c local_proto.h
...| no clones | 4 monsters |1 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Apr 27 04:25:00 EDT 2011
Hello hamish,
here's a report on your recent grass-SVN change for the revision : 46114
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/display/d.barb/points.c
*****************************************************************
Function
count_pts_in_region(Begins at: 99, Ends at:140)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 42 | | OK | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
do_barb_points(Begins at: 10, Ends at:96)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | * | WARNING | 13 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 28 | * | WARNING | 28 |
LOC: | 87 | * | WARNING | 87 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
fill_arrays(Begins at: 145, Ends at:277)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | ** | BABY-MONSTER | 21 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 39 | * | WARNING | 39 |
LOC: | 133 | * | WARNING | 133 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/display/d.barb/grid.c
*****************************************************************
Function
do_barb_grid(Begins at: 10, Ends at:193)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 31 | ** | BABY-MONSTER | 31 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 47 | ** | BABY-MONSTER | 47 |
LOC: | 184 | ** | BABY-MONSTER | 184 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/display/d.barb/main.c
*****************************************************************
Function
main(Begins at: 26, Ends at:264)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | * | WARNING | 19 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 90 | *** | MONSTER | 90 |
LOC: | 239 | *** | MONSTER | 239 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/display/d.barb/local_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/display/d.barb/legend.c
*****************************************************************
Function
do_legend(Begins at: 8, Ends at:74)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 67 | * | WARNING | 67 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Wed Apr 27 04:24:57 EDT 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 21 | 33 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 65 | 147 | 230 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list