[GRASS-QA] GRASS QA: hamish |do_geogrid.c | no clones | 0 monsters |3 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Fri Feb 18 01:56:00 EST 2011


Hello hamish,

here's a report on your recent grass-SVN change for the revision : 45425 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/ps/ps.map/do_geogrid.c
*****************************************************************

          Function
get_ll_bounds(Begins at: 287, Ends at:373)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |     * |      WARNING |        17 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      12 |       |           OK |        12 |
LOC:          |      87 |     * |      WARNING |        87 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


check_coords(Begins at: 383, Ends at:441)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      15 |       |           OK |        15 |
LOC:          |      59 |       |           OK |        59 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


do_geogrid_numbers(Begins at: 140, Ends at:258)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      15 |     * |      WARNING |        15 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      36 |     * |      WARNING |        36 |
LOC:          |     119 |     * |      WARNING |       119 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Fri Feb 18 01:55:43 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        66 |       148 |       231 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list