[GRASS-QA] GRASS QA: mmetz |rbtree.c | 2 clones | 0 monsters |2 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Tue Jan 11 13:31:04 EST 2011


Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 44962 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/btree2/rbtree.c
*****************************************************************

          Function
rbtree_destroy(Begins at: 411, Ends at:439)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      29 |       |           OK |        29 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


rbtree_debug(Begins at: 442, Ends at:492)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      11 |       |           OK |        11 |
LOC:          |      51 |       |           OK |        51 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


rbtree_remove(Begins at: 152, Ends at:236)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      16 |       |           OK |        16 |
LOC:          |      85 |     * |      WARNING |        85 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file has 2 potentially cloned functions:
  rbtree_debug

In /data/project-manager/grass/grassSVN/grass/trunk/lib/btree2/rbtree.c clones of rbtree_destroy are:
          /data/project-manager/grass/grassSVN/grass-addons/raster/r.stream.extract/rbtree.c  rbtree_destroy

In /data/project-manager/grass/grassSVN/grass/trunk/lib/btree2/rbtree.c clones of rbtree_debug are:
          /data/project-manager/grass/grassSVN/grass-addons/raster/r.stream.extract/rbtree.c  rbtree_debug

____________________________________________


Threshold grass key metrics values at Tue Jan 11 13:30:57 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        65 |       146 |       227 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list