[GRASS-QA] GRASS QA: martinl |mapset_msc.c file_name.c main.c
open.c ...| 12 clones | 5 monsters |37 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Mon Jan 17 14:11:27 EST 2011
Hello martinl,
here's a report on your recent grass-SVN change for the revision : 45071
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/gis/mapset_msc.c
*****************************************************************
Function
G__mapset_permissions(Begins at: 100, Ends at:120)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__make_mapset_element(Begins at: 35, Ends at:72)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 38 | | OK | 38 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/file_name.c
*****************************************************************
Function
G_file_name_misc(Begins at: 70, Ends at:112)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
G_file_name(Begins at: 33, Ends at:68)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 36 | | OK | 36 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.null/main.c
*****************************************************************
Function
main(Begins at: 29, Ends at:200)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | * | WARNING | 16 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 73 | *** | MONSTER | 73 |
LOC: | 172 | ** | BABY-MONSTER | 172 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/raster/open.c
*****************************************************************
Function
Rast__check_fp_type(Begins at: 821, Ends at:864)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 23 | * | WARNING | 23 |
LOC: | 44 | | OK | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Rast_map_is_fp(Begins at: 735, Ends at:754)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Rast_map_type(Begins at: 768, Ends at:793)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | | OK | 10 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
Rast_map_type
In /data/project-manager/grass/grassSVN/grass/trunk/lib/raster/open.c clones of Rast_map_is_fp are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/raster/opencell.c Rast_map_is_fp
In /data/project-manager/grass/grassSVN/grass/trunk/lib/raster/open.c clones of Rast_map_type are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/raster/opencell.c Rast_map_type
*****************************************************************
File :/lib/vector/Vlib/open_nat.c
*****************************************************************
Function
V1_open_new_nat(Begins at: 93, Ends at:139)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 17 | * | WARNING | 17 |
LOC: | 47 | | OK | 47 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/manage/do_copy.c
*****************************************************************
Function
do_copy(Begins at: 12, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 30 | * | WARNING | 30 |
LOC: | 55 | | OK | 55 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/raster/gdal.c
*****************************************************************
Class
GDAL_Options(Begins at: 336, Ends at:342)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
read_gdal_options(Begins at: 354, Ends at:391)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 38 | | OK | 38 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/include/gisdefs.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/init/clean_temp.c
*****************************************************************
Function
main(Begins at: 121, Ends at:171)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 51 | | OK | 51 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/close_ogr.c
*****************************************************************
Function
V2_close_ogr(Begins at: 73, Ends at:132)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 60 | | OK | 60 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.mremove/main.c
*****************************************************************
Function
main(Begins at: 38, Ends at:163)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | * | WARNING | 17 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 50 | ** | BABY-MONSTER | 50 |
LOC: | 126 | * | WARNING | 126 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/vector/v.proj/main.c
*****************************************************************
Function
main(Begins at: 34, Ends at:307)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 29 | ** | BABY-MONSTER | 29 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 128 | *** | MONSTER | 128 |
LOC: | 274 | *** | MONSTER | 274 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/make_loc.c
*****************************************************************
Function
G__make_location(Begins at: 44, Ends at:81)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 38 | | OK | 38 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/open_misc.c
*****************************************************************
Function
G__open_misc(Begins at: 31, Ends at:86)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 56 | | OK | 56 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.mlist/main.c
*****************************************************************
Function
make_list(Begins at: 237, Ends at:290)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 12 | | OK | 12 |
LOC: | 54 | | OK | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/general/g.mlist/main.c clones of make_list are:
/var/project-manager/grass/grassSVN/grass/trunk/general/g.mlist/main.c make_list
*****************************************************************
File :/lib/vector/Vlib/build.c
*****************************************************************
Function
Vect_save_sidx(Begins at: 517, Ends at:562)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 16 | | OK | 16 |
LOC: | 46 | | OK | 46 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_save_topo(Begins at: 242, Ends at:274)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
Vect_save_topo
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/build.c clones of Vect_save_sidx are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/build.c Vect_save_sidx
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/build.c clones of Vect_save_topo are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/build.c Vect_save_topo
*****************************************************************
File :/imagery/i.ortho.photo/lib/ls_cameras.c
*****************************************************************
Function
I_list_cameras(Begins at: 13, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 26 | * | WARNING | 26 |
LOC: | 53 | | OK | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/tempfile.c
*****************************************************************
Function
G__tempfile(Begins at: 71, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.mremove/check_reclass.c
*****************************************************************
Function
check_reclass(Begins at: 8, Ends at:66)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 59 | | OK | 59 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/manage/empty.c
*****************************************************************
Function
empty(Begins at: 6, Ends at:25)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/get_projinfo.c
*****************************************************************
Function
G_get_projunits(Begins at: 25, Ends at:41)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_get_projinfo(Begins at: 48, Ends at:64)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
G_get_projunits
In /data/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_projinfo.c clones of G_get_projunits are:
/data/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_projinfo.c G_get_projinfo
In /data/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_projinfo.c clones of G_get_projinfo are:
/data/project-manager/grass/grassSVN/grass/trunk/lib/gis/get_projinfo.c G_get_projunits
*****************************************************************
File :/imagery/i.ortho.photo/lib/ls_elev.c
*****************************************************************
Function
I_list_elev(Begins at: 12, Ends at:59)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 25 | * | WARNING | 25 |
LOC: | 48 | | OK | 48 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.access/main.c
*****************************************************************
Function
main(Begins at: 25, Ends at:89)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 24 | * | WARNING | 24 |
LOC: | 65 | | OK | 65 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/g3d/filename.c
*****************************************************************
Function
G3d_filename(Begins at: 9, Ends at:14)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/remove.c
*****************************************************************
Function
G__remove(Begins at: 71, Ends at:102)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 32 | | OK | 32 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/list.c
*****************************************************************
Function
list_element(Begins at: 97, Ends at:163)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 16 | | OK | 16 |
LOC: | 67 | * | WARNING | 67 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.proj/output.c
*****************************************************************
Function
create_location(Begins at: 156, Ends at:224)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 28 | * | WARNING | 28 |
LOC: | 69 | * | WARNING | 69 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.find/main.c
*****************************************************************
Function
find(Begins at: 104, Ends at:149)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 46 | | OK | 46 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.remove/main.c
*****************************************************************
Function
check_reclass(Begins at: 28, Ends at:83)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 56 | | OK | 56 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/cindex.c
*****************************************************************
Function
Vect_cidx_save(Begins at: 443, Ends at:475)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 15 | | OK | 15 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_cidx_open(Begins at: 487, Ends at:527)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/header.c
*****************************************************************
Function
lookup(Begins at: 691, Ends at:697)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.setproj/main.c
*****************************************************************
Function
main(Begins at: 50, Ends at:651)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 108 | *** | MONSTER | 108 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 292 | *** | MONSTER | 292 |
LOC: | 602 | *** | MONSTER | 602 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.findfile/main.c
*****************************************************************
Function
main(Begins at: 24, Ends at:118)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 44 | ** | BABY-MONSTER | 44 |
LOC: | 95 | * | WARNING | 95 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/r.support/main.c
*****************************************************************
Function
main(Begins at: 34, Ends at:320)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 30 | *** | MONSTER | 30 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 118 | *** | MONSTER | 118 |
LOC: | 287 | *** | MONSTER | 287 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/open.c
*****************************************************************
Function
G__open(Begins at: 49, Ends at:104)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 56 | | OK | 56 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/close.c
*****************************************************************
Function
Vect_close(Begins at: 65, Ends at:157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 37 | * | WARNING | 37 |
LOC: | 93 | * | WARNING | 93 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/map.c
*****************************************************************
Function
Vect_copy(Begins at: 222, Ends at:357)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | * | WARNING | 16 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 62 | ** | BABY-MONSTER | 62 |
LOC: | 136 | * | WARNING | 136 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/raster/close.c
*****************************************************************
Function
close_new(Begins at: 334, Ends at:467)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 44 | ** | BABY-MONSTER | 44 |
LOC: | 134 | * | WARNING | 134 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
close_new_gdal(Begins at: 255, Ends at:332)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 30 | * | WARNING | 30 |
LOC: | 78 | * | WARNING | 78 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
write_support_files(Begins at: 178, Ends at:253)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 76 | * | WARNING | 76 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
write_fp_format(Begins at: 470, Ends at:496)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/open.c
*****************************************************************
Function
Vect_open_topo(Begins at: 932, Ends at:1003)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 15 | | OK | 15 |
LOC: | 72 | * | WARNING | 72 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect__open_old(Begins at: 152, Ends at:497)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 44 | *** | MONSTER | 44 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 132 | *** | MONSTER | 132 |
LOC: | 346 | *** | MONSTER | 346 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_open_sidx(Begins at: 1014, Ends at:1113)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 100 | * | WARNING | 100 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Vect_coor_info(Begins at: 828, Ends at:868)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | | OK | 10 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 4 potentially cloned functions:
Vect__open_old Vect_open_sidx Vect_coor_info
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect_open_topo are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_topo
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect__open_old are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect__open_old
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect_open_sidx are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_open_sidx
In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c clones of Vect_coor_info are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/open.c Vect_coor_info
*****************************************************************
File :/lib/gis/rename.c
*****************************************************************
Function
G_rename(Begins at: 59, Ends at:82)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/myname.c
*****************************************************************
Function
G_myname(Begins at: 31, Ends at:49)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/db/drivers/dbf/table.c
*****************************************************************
Function
save_table(Begins at: 213, Ends at:309)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | * | WARNING | 18 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 97 | * | WARNING | 97 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/raster/reclass.c
*****************************************************************
Function
Rast_put_reclass(Begins at: 260, Ends at:352)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | * | WARNING | 18 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 32 | * | WARNING | 32 |
LOC: | 93 | * | WARNING | 93 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/gis/find_file.c
*****************************************************************
Function
find_file(Begins at: 21, Ends at:111)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | * | WARNING | 15 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 91 | * | WARNING | 91 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/lib/gis/find_file.c clones of find_file are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/gis/find_file.c find_file
*****************************************************************
File :/lib/gis/get_ellipse.c
*****************************************************************
Function
G_get_ellipsoid_parameters(Begins at: 67, Ends at:90)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/general/g.filename/main.c
*****************************************************************
Function
main(Begins at: 25, Ends at:82)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 58 | | OK | 58 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/g3d/g3dwindowio.c
*****************************************************************
Function
G3d_getFullWindowPath(Begins at: 61, Ends at:84)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Mon Jan 17 14:11:18 EST 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 66 | 148 | 231 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list