[GRASS-QA] GRASS QA: mmetz |buffer2.c | no clones | 3 monsters |12
warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Jan 26 14:28:26 EST 2011
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 45201
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/vector/Vlib/buffer2.c
*****************************************************************
Function
destroy_lines_array(Begins at: 829, Ends at:836)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
point_in_buf(Begins at: 718, Ends at:787)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
extract_outer_contour(Begins at: 631, Ends at:673)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
line_coefficients(Begins at: 129, Ends at:137)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
rotate_vector(Begins at: 61, Ends at:68)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
buffer_lines(Begins at: 841, Ends at:939)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | * | WARNING | 14 |
ParamNBR: | 13 | *** | MONSTER | 13 |
CalledNBR: | 39 | * | WARNING | 39 |
LOC: | 99 | * | WARNING | 99 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_area_buffer2(Begins at: 1017, Ends at:1068)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 11 | *** | MONSTER | 11 |
CalledNBR: | 17 | * | WARNING | 17 |
LOC: | 52 | | OK | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
elliptic_tangent(Begins at: 104, Ends at:123)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_line_buffer2(Begins at: 958, Ends at:1000)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
norm_vector(Begins at: 40, Ends at:59)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
elliptic_transform(Begins at: 74, Ends at:96)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
add_line_to_array(Begins at: 814, Ends at:827)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
get_polygon_orientation(Begins at: 791, Ends at:811)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
extract_contour(Begins at: 492, Ends at:619)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | * | WARNING | 15 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 128 | * | WARNING | 128 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
angular_tolerance(Begins at: 163, Ends at:171)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_point_buffer2(Begins at: 1082, Ends at:1119)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 38 | | OK | 38 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Wed Jan 26 14:28:18 EST 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 65 | 146 | 227 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list